Skip to content

Use "className" instead of "class" in React components #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 26, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.

### [1.26.3](https://github.com/n1c0de/react-json-view/compare/v1.26.2...v1.26.3) (2025-05-26)

### [1.26.2](https://github.com/microlinkhq/react-json-view/compare/v1.26.1...v1.26.2) (2025-05-16)

### [1.26.1](https://github.com/microlinkhq/react-json-view/compare/v1.26.0...v1.26.1) (2025-02-15)
Expand Down
54 changes: 27 additions & 27 deletions docs/src/js/components/Demo.js
Original file line number Diff line number Diff line change
Expand Up @@ -175,9 +175,9 @@ class Demo extends React.PureComponent {
`}
</style>
)}
<div class='rjv-demo'>
<div class='rjv-header'>
<div class='header-1'>@microlink/react-json-view</div>
<div className='rjv-demo'>
<div className='rjv-header'>
<div className='header-1'>@microlink/react-json-view</div>
</div>
<ReactJson
name={false}
Expand Down Expand Up @@ -217,52 +217,52 @@ class Demo extends React.PureComponent {
iconStyle={iconStyle}
/>

<div class='rjv-settings'>
<div class='rjv-input'>
<div class='rjv-label'>Theme:</div>
<div className='rjv-settings'>
<div className='rjv-input'>
<div className='rjv-label'>Theme:</div>
{this.getThemeInput(theme)}
</div>
<div class='rjv-input'>
<div class='rjv-label'>Icon Style:</div>
<div className='rjv-input'>
<div className='rjv-label'>Icon Style:</div>
{this.getIconStyleInput(iconStyle)}
</div>
<div class='rjv-input'>
<div class='rjv-label'>Enable Edit:</div>
<div className='rjv-input'>
<div className='rjv-label'>Enable Edit:</div>
{this.getEditInput(onEdit)}
</div>
<div class='rjv-input'>
<div class='rjv-label'>Enable Add:</div>
<div className='rjv-input'>
<div className='rjv-label'>Enable Add:</div>
{this.getAddInput(onAdd)}
</div>
<div class='rjv-input'>
<div class='rjv-label'>Enable Delete:</div>
<div className='rjv-input'>
<div className='rjv-label'>Enable Delete:</div>
{this.getDeleteInput(onDelete)}
</div>
<div class='rjv-input'>
<div class='rjv-label'>Enable Clipboard:</div>
<div className='rjv-input'>
<div className='rjv-label'>Enable Clipboard:</div>
{this.getEnableClipboardInput(enableClipboard)}
</div>
</div>

<div class='rjv-settings'>
<div class='rjv-input'>
<div class='rjv-label'>Display Data Types:</div>
<div className='rjv-settings'>
<div className='rjv-input'>
<div className='rjv-label'>Display Data Types:</div>
{this.getDataTypesInput(displayDataTypes)}
</div>
<div class='rjv-input'>
<div class='rjv-label'>Display Object Size:</div>
<div className='rjv-input'>
<div className='rjv-label'>Display Object Size:</div>
{this.getObjectSizeInput(displayObjectSize)}
</div>
<div class='rjv-input'>
<div class='rjv-label'>Indent Width:</div>
<div className='rjv-input'>
<div className='rjv-label'>Indent Width:</div>
{this.getIndentWidthInput(indentWidth)}
</div>
<div class='rjv-input'>
<div class='rjv-label'>Collapsed:</div>
<div className='rjv-input'>
<div className='rjv-label'>Collapsed:</div>
{this.getCollapsedInput(collapsed)}
</div>
<div class='rjv-input'>
<div class='rjv-label'>Collapse Strings After Length:</div>
<div className='rjv-input'>
<div className='rjv-label'>Collapse Strings After Length:</div>
{this.getCollapsedStringsInput(collapseStringsAfter)}
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion docs/src/js/entry.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const app = document.getElementById('mac-react-container')

//app entrypoint
ReactDom.render(
<div class='app-entry'>
<div className='app-entry'>
<Index />
</div>,
app
Expand Down
2 changes: 1 addition & 1 deletion docs/src/js/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import ReactJsonDemo from './components/Demo'
// index entrypoint component
export default function Demo () {
return (
<div class='mac-react'>
<div className='mac-react'>
<ReactJsonDemo />
</div>
)
Expand Down
6 changes: 5 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "@microlink/react-json-view",
"description": "Interactive react component for displaying javascript arrays and JSON objects.",
"homepage": "https://github.com/microlinkhq/react-json-view",
"version": "1.26.2",
"version": "1.26.3",
"main": "dist/main.js",
"author": {
"name": "Mac Gainor"
Expand Down Expand Up @@ -175,6 +175,10 @@
{
"name": "Mert Donmezyurek",
"email": "[email protected]"
},
{
"name": "n1c0de",
"email": "[email protected]"
}
],
"repository": {
Expand Down
12 changes: 6 additions & 6 deletions src/js/components/ArrayGroup.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ export default class extends React.PureComponent {

return (
<div
class='object-key-val'
className='object-key-val'
{...Theme(theme, jsvRoot ? 'jsv-root' : 'objectKeyVal', {
paddingLeft: object_padding_left
})}
Expand All @@ -79,15 +79,15 @@ export default class extends React.PureComponent {
{[...Array(groups)].map((_, i) => (
<div
key={i}
class='object-key-val array-group'
className='object-key-val array-group'
{...Theme(theme, 'objectKeyVal', {
marginLeft: 6,
paddingLeft: array_group_padding_left
})}
>
<span {...Theme(theme, 'brace-row')}>
<div
class='icon-container'
className='icon-container'
{...Theme(theme, 'icon-container')}
onClick={e => {
this.toggleCollapsed(i)
Expand Down Expand Up @@ -118,14 +118,14 @@ export default class extends React.PureComponent {
onClick={e => {
this.toggleCollapsed(i)
}}
class='array-group-brace'
className='array-group-brace'
>
[
<div
{...Theme(theme, 'array-group-meta-data')}
class='array-group-meta-data'
className='array-group-meta-data'
>
<span class='object-size' {...Theme(theme, 'object-size')}>
<span className='object-size' {...Theme(theme, 'object-size')}>
{i * size}
{' - '}
{i * size + size > src.length
Expand Down
4 changes: 2 additions & 2 deletions src/js/components/CopyToClipboard.js
Original file line number Diff line number Diff line change
Expand Up @@ -74,13 +74,13 @@ export default class extends React.PureComponent {
if (this.state.copied) {
return (
<span>
<Clippy class='copy-icon' {...Theme(theme, 'copy-icon')} />
<Clippy className='copy-icon' {...Theme(theme, 'copy-icon')} />
<span {...Theme(theme, 'copy-icon-copied')}>✔</span>
</span>
)
}

return <Clippy class='copy-icon' {...Theme(theme, 'copy-icon')} />
return <Clippy className='copy-icon' {...Theme(theme, 'copy-icon')} />
}

clipboardValue = value => {
Expand Down
2 changes: 1 addition & 1 deletion src/js/components/DataTypes/DataTypeLabel.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export default class extends React.PureComponent {
const { rjvId, type_name, displayDataTypes, theme } = this.props
if (displayDataTypes) {
return (
<span class='data-type-label' {...Theme(theme, 'data-type-label')}>
<span className='data-type-label' {...Theme(theme, 'data-type-label')}>
{type_name}
</span>
)
Expand Down
2 changes: 1 addition & 1 deletion src/js/components/DataTypes/Date.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export default class extends React.PureComponent {
return (
<div {...Theme(props.theme, 'date')}>
<DataTypeLabel type_name={type_name} {...props} />
<span class='date-value' {...Theme(props.theme, 'date-value')}>
<span className='date-value' {...Theme(props.theme, 'date-value')}>
{props.value.toLocaleTimeString('en-us', display_options)}
</span>
</div>
Expand Down
4 changes: 2 additions & 2 deletions src/js/components/DataTypes/Function.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export default class extends React.PureComponent {
<DataTypeLabel type_name={type_name} {...props} />
<span
{...Theme(props.theme, 'function-value')}
class='rjv-function-container'
className='rjv-function-container'
onClick={this.toggleCollapsed}
>
{this.getFunctionDisplay(collapsed)}
Expand All @@ -65,7 +65,7 @@ export default class extends React.PureComponent {
.toString()
.slice(9, -1)
.replace(/\{[\s\S]+/, '')}
<span class='function-collapsed' style={{ fontWeight: 'bold' }}>
<span className='function-collapsed' style={{ fontWeight: 'bold' }}>
<span>{'{'}</span>
<span {...Theme(props.theme, 'ellipsis')}>...</span>
<span>{'}'}</span>
Expand Down
12 changes: 6 additions & 6 deletions src/js/components/DataTypes/Object.js
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,9 @@ class RjvObject extends React.PureComponent {

getObjectContent = (depth, src, props) => {
return (
<div class='pushed-content object-container'>
<div className='pushed-content object-container'>
<div
class='object-content'
className='object-content'
{...Theme(this.props.theme, 'pushed-content')}
>
{this.renderObjectContents(src, props)}
Expand All @@ -120,7 +120,7 @@ class RjvObject extends React.PureComponent {
return (
<div
{...Theme(this.props.theme, 'ellipsis')}
class='node-ellipsis'
className='node-ellipsis'
onClick={this.toggleCollapsed}
>
...
Expand Down Expand Up @@ -159,7 +159,7 @@ class RjvObject extends React.PureComponent {
}}
{...Theme(theme, 'brace-row')}
>
<div class='icon-container' {...Theme(theme, 'icon-container')}>
<div className='icon-container' {...Theme(theme, 'icon-container')}>
<IconComponent {...{ theme, iconStyle }} />
</div>
<ObjectName {...this.props} />
Expand Down Expand Up @@ -200,7 +200,7 @@ class RjvObject extends React.PureComponent {

return (
<div
class='object-key-val'
className='object-key-val'
onMouseEnter={() => this.setState({ ...this.state, hovered: true })}
onMouseLeave={() => this.setState({ ...this.state, hovered: false })}
{...Theme(theme, jsvRoot ? 'jsv-root' : 'objectKeyVal', styles)}
Expand All @@ -213,7 +213,7 @@ class RjvObject extends React.PureComponent {
...rest
})
: this.getEllipsis()}
<span class='brace-row'>
<span className='brace-row'>
<span
style={{
...Theme(theme, 'brace').style,
Expand Down
2 changes: 1 addition & 1 deletion src/js/components/DataTypes/String.js
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ export default class extends React.PureComponent {
return (
<div {...Theme(theme, 'string')}>
<DataTypeLabel type_name={type_name} {...props} />
<span class='string-value' {...style} onClick={this.toggleCollapsed}>
<span className='string-value' {...style} onClick={this.toggleCollapsed}>
"{value}"
</span>
</div>
Expand Down
4 changes: 2 additions & 2 deletions src/js/components/JsonViewer.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ export default class extends React.PureComponent {
}

return (
<div class='pretty-json-container object-container'>
<div class='object-content'>
<div className='pretty-json-container object-container'>
<div className='object-content'>
<ObjectComponent namespace={namespace} depth={0} jsvRoot {...props} />
</div>
</div>
Expand Down
8 changes: 4 additions & 4 deletions src/js/components/ObjectKeyModal/ObjectKeyModal.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export default class extends React.PureComponent {

return (
<div
class='key-modal-request'
className='key-modal-request'
{...Theme(theme, 'key-modal-request')}
onClick={this.closeModal}
>
Expand All @@ -37,7 +37,7 @@ export default class extends React.PureComponent {
<div style={{ position: 'relative' }}>
<input
{...Theme(theme, 'key-modal-input')}
class='key-modal-input'
className='key-modal-input'
ref={el => el && el.focus()}
spellCheck={false}
value={input}
Expand All @@ -59,7 +59,7 @@ export default class extends React.PureComponent {
? (
<CheckCircle
{...Theme(theme, 'key-modal-submit')}
class='key-modal-submit'
className='key-modal-submit'
onClick={e => this.submit()}
/>
)
Expand All @@ -68,7 +68,7 @@ export default class extends React.PureComponent {
<span {...Theme(theme, 'key-modal-cancel')}>
<Cancel
{...Theme(theme, 'key-modal-cancel-icon')}
class='key-modal-cancel'
className='key-modal-cancel'
onClick={() => {
dispatcher.dispatch({
rjvId,
Expand Down
4 changes: 2 additions & 2 deletions src/js/components/ObjectName.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export default function getObjectName (props) {
return displayArrayKey
? (
<span {...Theme(theme, 'array-key')} key={namespace}>
<span class='array-key'>{display_name}</span>
<span className='array-key'>{display_name}</span>
<span {...Theme(theme, 'colon')}>:</span>
</span>
)
Expand All @@ -30,7 +30,7 @@ export default function getObjectName (props) {
} else {
return (
<span {...Theme(theme, 'object-name')} key={namespace}>
<span class='object-key'>
<span className='object-key'>
{quotesOnKeys && <span style={{ verticalAlign: 'top' }}>"</span>}
<span>{display_name}</span>
{quotesOnKeys && <span style={{ verticalAlign: 'top' }}>"</span>}
Expand Down
12 changes: 6 additions & 6 deletions src/js/components/ToggleIcons.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,15 @@ export function ExpandedIcon (props) {
switch (iconStyle) {
case 'triangle':
return (
<ArrowDown {...Theme(theme, 'expanded-icon')} class='expanded-icon' />
<ArrowDown {...Theme(theme, 'expanded-icon')} className='expanded-icon' />
)
case 'square':
return (
<SquareMinus {...Theme(theme, 'expanded-icon')} class='expanded-icon' />
<SquareMinus {...Theme(theme, 'expanded-icon')} className='expanded-icon' />
)
default:
return (
<CircleMinus {...Theme(theme, 'expanded-icon')} class='expanded-icon' />
<CircleMinus {...Theme(theme, 'expanded-icon')} className='expanded-icon' />
)
}
}
Expand All @@ -35,21 +35,21 @@ export function CollapsedIcon (props) {
return (
<ArrowRight
{...Theme(theme, 'collapsed-icon')}
class='collapsed-icon'
className='collapsed-icon'
/>
)
case 'square':
return (
<SquarePlus
{...Theme(theme, 'collapsed-icon')}
class='collapsed-icon'
className='collapsed-icon'
/>
)
default:
return (
<CirclePlus
{...Theme(theme, 'collapsed-icon')}
class='collapsed-icon'
className='collapsed-icon'
/>
)
}
Expand Down
Loading