Skip to content

Fix editorconfig-checker deprecations #1425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

skupjoe
Copy link
Contributor

@skupjoe skupjoe commented Mar 23, 2025

New Behavior

  1. Fix editorconfig-checker config filename format:
$ editorconfig-checker
The default configuration file name .ecrc is deprecated. Use .editorconfig-checker.json instead. You can simply rename it
  1. Fix unsupported non-JSON
$ editorconfig-checker
invalid character '/' looking for beginning of object key string
  1. Fix deprecated config name
$ editorconfig-checker
The configuration key `SpacesAftertabs` is deprecated. Use `SpacesAfterTabs` instead.

Contrast to Current Behavior

The latest version of editorconfig-checker (3.2.1) fails with errors/deprecation warnings.

Proposed Release Note Entry

Fix editorconfig-checker deprecations

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

@skupjoe
Copy link
Contributor Author

skupjoe commented Mar 23, 2025

Sorry I based this from release branch but pulled latest develop into it

@tobiasge tobiasge force-pushed the fix-editorconfig-checker branch from 49a3f2b to c8bd177 Compare March 24, 2025 13:19
@tobiasge tobiasge enabled auto-merge March 24, 2025 13:19
@tobiasge tobiasge merged commit 1c30173 into netbox-community:develop Mar 24, 2025
7 of 9 checks passed
@tobiasge tobiasge mentioned this pull request May 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants