Skip to content

hightime: Add support for Python 3.10-3.13 and drop Python 3.7-3.8 #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 2, 2025

Conversation

bkeryan
Copy link
Collaborator

@bkeryan bkeryan commented Mar 26, 2025

What does this Pull Request accomplish?

Update Python versions in tox.ini and trove classifiers to match NI's Python support policy.

Update datetime to use __index__ to implicitly convert parameters to int, rather than using __int__. This follows python/cpython#15636 from Python 3.10.

Why should this Pull Request be merged?

Fixes #42

The GitHub-hosted runner no longer supports Python 3.7 or 3.8.

What testing has been done?

Ran pyenv global 3.9.13 3.10.11 3.11.9 3.12.9 3.13.2 and tox:

  py39-test: OK (1.44=setup[0.08]+cmd[0.05,0.09,1.22] seconds)
  py310-test: OK (1.44=setup[0.01]+cmd[0.05,0.11,1.26] seconds)
  py311-test: OK (1.44=setup[0.00]+cmd[0.06,0.08,1.30] seconds)
  py312-test: OK (1.55=setup[0.00]+cmd[0.06,0.09,1.39] seconds)
  py313-test: OK (1.51=setup[0.01]+cmd[0.03,0.08,1.39] seconds)
  pypy-test: SKIP (0.03 seconds)
  pypy3-test: SKIP (0.03 seconds)
  flake8: OK (0.83=setup[0.01]+cmd[0.06,0.08,0.67] seconds)
  black: OK (0.80=setup[0.00]+cmd[0.05,0.09,0.66] seconds)
  congratulations :) (9.17 seconds)

Verified that pytest prints "Python 3.13.2" etc.

bkeryan added 4 commits March 25, 2025 18:35
`datetime` used to accept objects that implement `__int__` or `__index__`, but in Python 3.10 it was changed to accept only `__index__`.
python/cpython#15636
@bkeryan bkeryan mentioned this pull request Mar 26, 2025
1 task
@bkeryan bkeryan requested a review from tkrebes April 1, 2025 15:47
@tkrebes tkrebes merged commit b9913eb into ni:master Apr 2, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add official support for Python 3.10, 3.11 and probably 3.12
2 participants