show reconnection popup on third attempt #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choyrim
approved these changes
Nov 9, 2020
mgmachado
force-pushed
the
feature/suppress_reconnect_popups_at_first
branch
from
2741bf3 to
b2abfa7
Compare
|
@mgmachado synced fork (nielsen) from upstream and rebased and tested. so merging. |
|
The corresponding PR to the upstream project is at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue this PR solves: coder#1791
On a connection loss, the client attempts to reconnect up to twice in the background before displaying the reconnection pop-up.