Skip to content

update(pkgs): Update geth, nethermind, nimbus, web3signer and mev-boost packages #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

update(pkgs): Update geth, nethermind, nimbus, web3signer and mev-boost packages #574

wants to merge 6 commits into from

Conversation

MartinNikov
Copy link
Contributor

@MartinNikov MartinNikov commented Feb 19, 2025 •
edited
Loading

  • chore(flake.lock): Update all Flake inputs (2025-03-04)
  • nethermind: 1.30.3 > 1.31.3
  • geth: 1.14.13 > 1.15.4
  • mev-boost: 1.8 > 1.9-rc2
  • web3signer: 24.2.0 > 25.2.0
  • nimbus: 24.12.0 > 25.3.0

bbjubjub2494
bbjubjub2494 reviewed Feb 19, 2025
View reviewed changes
@MartinNikov MartinNikov force-pushed the update-packages branch 2 times, most recently from 2285b10 to a988c6b Compare February 20, 2025 12:10
@MartinNikov MartinNikov marked this pull request as draft February 20, 2025 12:40
@MartinNikov MartinNikov force-pushed the update-packages branch 2 times, most recently from 50aeb33 to 142f794 Compare February 20, 2025 13:03
@MartinNikov MartinNikov marked this pull request as ready for review February 20, 2025 13:09
bbjubjub2494
bbjubjub2494 requested changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@bbjubjub2494 bbjubjub2494 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the dependency bump changed the dep hash for blutgang. https://buildbot.nix-community.org/#/builders/1605/builds/60

I looked into it, it looks like the contents of the tarballs are identical, only some files appear in a different order in the tarball.

Please also run treefmt at the end

bbjubjub2494
bbjubjub2494 requested changes Feb 20, 2025
View reviewed changes
bbjubjub2494
bbjubjub2494 approved these changes Feb 22, 2025
View reviewed changes
Copy link
Collaborator

@bbjubjub2494 bbjubjub2494 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me, still needs a treefmt

@yakimant
Copy link

Pectra release is today on holesky:
https://blog.ethereum.org/2025/02/14/pectra-testnet-announcement#client-releases
Geth/Nethermind upgrades in this PR are mandatory.

@yakimant
Copy link

Pectra for Holesky didnt work well, so more upgrades needed for both geth and nethermind.

@yakimant
Copy link

@bbjubjub2494 bbjubjub2494 mentioned this pull request Mar 2, 2025
Closed
@bbjubjub2494
Copy link
Collaborator

The build should be fixed with facc2b3

@MartinNikov MartinNikov force-pushed the update-packages branch 3 times, most recently from e70d16d to f6988d8 Compare March 6, 2025 09:15
@MartinNikov
Copy link
Contributor Author

Finally, all checks have passed. Regarding mdformat, I used the old version because the newest one was broken. Is that fine with you, @bbjubjub2494?

@bbjubjub2494
Copy link
Collaborator

Finally, all checks have passed. Regarding mdformat, I used the old version because the newest one was broken. Is that fine with you, @bbjubjub2494?

I'm not an authority on mdformat, but afaik there's no other known solution so no objections

bbjubjub2494
bbjubjub2494 previously approved these changes Mar 6, 2025
View reviewed changes
Copy link
Collaborator

@bbjubjub2494 bbjubjub2494 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MartinNikov
Copy link
Contributor Author

@aldoborrero can you review and approve so we can merge the PR

@ekimber
Copy link
Contributor

ekimber commented Mar 6, 2025

Not sure about using release candidates

MartinNikov and others added 3 commits March 7, 2025 10:39
@MartinNikov
chore(flake.lock): Update all Flake inputs (2025-03-04)
23ddfac 
```
• Updated input 'devour-flake':
    'github:srid/devour-flake/017e3a0eb62e2a3d63fb20c5028af71f39a81181?narHash=sha256-RrSH%2B9vlDDDh%2ByZao012bvV8Hoej/5poQQYfYlEr6Zw%3D' (2024-12-03)
  → 'github:srid/devour-flake/9fe4db872c107ea217c13b24527b68d9e4a4c01b?narHash=sha256-R7MHvTh5fskzxNLBe9bher%2BGQBZ8ZHjz75CPQG3fSRI%3D' (2025-02-04)
• Updated input 'flake-parts':
    'github:hercules-ci/flake-parts/b905f6fc23a9051a6e1b741e1438dbfc0634c6de?narHash=sha256-%2Bhu54pAoLDEZT9pjHlqL9DNzWz0NbUn8NEAHP7PQPzU%3D' (2025-01-06)
  → 'github:hercules-ci/flake-parts/3876f6b87db82f33775b1ef5ea343986105db764?narHash=sha256-ZaMw0pdoUKigLpv9HiNDH2Pjnosg7NBYMJlHTIsHEUo%3D' (2025-03-01)
• Updated input 'foundry-nix':
    'github:shazow/foundry.nix/14f071541283aa90e15efc980121a8296f70a2d3?narHash=sha256-PAyEy36HBOOwzChB7D6xKzzkHwiK9ynsRX4/0ZFspgI%3D' (2025-01-04)
  → 'github:shazow/foundry.nix/ed2a08376f14c0caf2b97418c91a66872e5ab3e2?narHash=sha256-XY6CUZft7wjB/cbLyi/xeOZHh2mizSAT0EaYo9wuRXI%3D' (2025-03-03)
• Updated input 'nixpkgs-unstable':
    'github:nixos/nixpkgs/8c9fd3e564728e90829ee7dbac6edc972971cd0f?narHash=sha256-CHd7yhaDigUuJyDeX0SADbTM9FXfiWaeNyY34FL1wQU%3D' (2025-01-07)
  → 'github:nixos/nixpkgs/02032da4af073d0f6110540c8677f16d4be0117f?narHash=sha256-SvtvVKHaUX4Owb%2BPasySwZsoc5VUeTf1px34BByiOxw%3D' (2025-03-03)
• Updated input 'treefmt-nix':
    'github:numtide/treefmt-nix/13c913f5deb3a5c08bb810efd89dc8cb24dd968b?narHash=sha256-p2r8xhQZ3TYIEKBoiEhllKWQqWNJNoT9v64Vmg4q8Zw%3D' (2025-01-06)
  → 'github:numtide/treefmt-nix/3d0579f5cc93436052d94b73925b48973a104204?narHash=sha256-mL1szCeIsjh6Khn3nH2cYtwO5YXG6gBiTw1A30iGeDU%3D' (2025-02-17)
```
@MartinNikov @Syndamia
nethermind: 1.30.3 > 1.31.3
ebaa4a0 
Co-authored-by: Kamen Mladenov <[email protected]>
@MartinNikov
geth: 1.14.13 > 1.15.4
04526d0
@MartinNikov
Copy link
Contributor Author

Why not? The hard fork required those versions.

@aldoborrero
Copy link
Collaborator

aldoborrero commented Mar 7, 2025 •
edited
Loading

Hi everybody,

just a couple of things:

  1. We can disable mdformat if it causes more issues. I was initially maintaining the package on nixpkgs but haven't had more time to do it properly, and there are some community members who stepped up. So, if it brings any issues, we can just disable the flag until it's fixed.
  2. In terms of using rc I'm not against it for Consensus or Execution clients as long as it makes sense for new network forks. I guess there's now a necessity of having multiple versions in place (i.e, the stable and the rc).
  3. @MartinNikov can you review this failure?

EDIT: By the way, thank you all for keeping pushing and maintaining the project.

@bbjubjub2494
Copy link
Collaborator

bbjubjub2494 commented Apr 22, 2025 •
edited
Loading

As agreed with @MartinNikov I am taking over this PR and splitting it

@bbjubjub2494 bbjubjub2494 mentioned this pull request Apr 22, 2025
Closed
@bbjubjub2494
Copy link
Collaborator

all changes have been merged in equivalent PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbjubjub2494 bbjubjub2494 bbjubjub2494 left review comments

@PetarKirov PetarKirov Awaiting requested review from PetarKirov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MartinNikov @yakimant @bbjubjub2494 @ekimber @aldoborrero @PetarKirov