-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
Closed
Labels
bufferIssues and PRs related to the buffer subsystem.Issues and PRs related to the buffer subsystem.docIssues and PRs related to the documentations.Issues and PRs related to the documentations.good first issueIssues that are suitable for first-time contributors.Issues that are suitable for first-time contributors.
Description
The documentation for these methods has the following:
buf.writeDoubleBE(0xdeadbeefcafebabe, 0);
However 0xdeadbeefcafebabe
a particularly poor value choice. To the naive reader, it implies this method is for writing 64-bit integers, and that JS supports 64 bit integers (which it doesn't. E.g. (0xdeadbeefcafebabe).toString(16)
yields deadbeefcafeb800
).
It would be clearer if the example used something like 1234.5678
or Math.PI
or 1.2345e67
.
Metadata
Metadata
Assignees
Labels
bufferIssues and PRs related to the buffer subsystem.Issues and PRs related to the buffer subsystem.docIssues and PRs related to the documentations.Issues and PRs related to the documentations.good first issueIssues that are suitable for first-time contributors.Issues that are suitable for first-time contributors.