NodeJS 22 throws std::bad_alloc when calling std::regex

[Retribution98]

Version

v22.14.0

Platform

Run on `Ubuntu 22.04.4 LTS`
Build on `CentOS Linux 7 (Core)`

Subsystem

No response

What steps will reproduce the bug?

1. Create addon.cpp using regex.

#include <napi.h>
#include <regex>

const std::regex UNIVERSAL_PATTERN{R"(\d+)"};

Napi::Object Init(Napi::Env env, Napi::Object exports) {
    return exports;
}

NODE_API_MODULE(test, Init)

2. Create CMakeLists.txt.

set(CMAKE_CXX_STANDARD 17)
cmake_minimum_required(VERSION 3.18)
set(dist_folder "${CMAKE_SOURCE_DIR}/bin/")
project(test)
add_definitions(-DNAPI_VERSION=8)
include(FetchContent)
FetchContent_Declare(
    node-api-headers
    URL      https://github.com/nodejs/node-api-headers/archive/refs/tags/v1.1.0.tar.gz
    URL_HASH SHA256=70608bc1e6dddce280285f3462f18a106f687c0720a4b90893e1ecd86e5a8bbf
)
FetchContent_MakeAvailable(node-api-headers)
FetchContent_Declare(
    node-addon-api
    URL      https://github.com/nodejs/node-addon-api/archive/refs/tags/v8.0.0.tar.gz
    URL_HASH SHA256=42424c5206b9d67b41af4fcff5d6e3cb22074168035a03b8467852938a281d47
)
FetchContent_MakeAvailable(node-addon-api)
add_library(${PROJECT_NAME} SHARED
    ${CMAKE_CURRENT_SOURCE_DIR}/addon.cpp
    ${CMAKE_JS_SRC}
)
target_include_directories(${PROJECT_NAME} PRIVATE
  "${node-api-headers_SOURCE_DIR}/include"
  "${node-addon-api_SOURCE_DIR}"
)
target_link_libraries(${PROJECT_NAME} PRIVATE ${DELAYIMP_LIB} ${CMAKE_JS_LIB})
set_target_properties(${PROJECT_NAME} PROPERTIES
    PREFIX ""
    SUFFIX ".node")
add_custom_command(
    TARGET ${PROJECT_NAME} POST_BUILD
    COMMAND ${CMAKE_COMMAND} -E make_directory ${dist_folder}
    COMMAND ${CMAKE_COMMAND} -E copy $<TARGET_FILE:${PROJECT_NAME}> ${dist_folder}
)

3. Build the addon on CentOS using docker

docker run --rm -v $(pwd):/work/src -w /work/src -it quay.io/pypa/manylinux2014_x86_64 /bin/bash -c "mkdir build && cd build && cmake -DCMAKE_LIBRARY_OUTPUT_DIRECTORY=../bin .. && cmake --build . && cmake --install ."

4. Import the addon from NodeJS 22 on Ubuntu

const addon = require('./bin/test.node');

How often does it reproduce? Is there a required condition?

✔️ If addon is built on CentOS and run from CentOS - it works
✔️ If addon is built on Ubuntu and run from Ubuntu - it works
❌ If addon is built on CentOS and run from Ubuntu - it doesn't work

What is the expected behavior? Why is that the expected behavior?

The addon has been successfully imported.

What do you see instead?

terminate called after throwing an instance of 'std::bad_alloc'
  what():  std::bad_alloc

Additional information

This works for NodeJS 20 and older.

[legendecas]

I don't think this is a node-api or Node.js issue. It seems to me that in the issue you are trying to build on a linux distribution but run it on another distribution and caused incompatiblity issue with the standard libraries.

Please checkout the supported platforms on https://github.com/nodejs/node/blob/v22.x/BUILDING.md#platform-list.

[mhdawson]

Can you share the exact versions of the compilers you are using as well as the exact versions of the ubuntu and centos?

[thunder-coding]

It's likely due to using shared libc++, try building with static libc++, and the binaries should be pretty much universal and only depend on libc

[mhdawson]

Knowing the versions of centos used would help understand. I agree that it a very likely reason is the shared libc++.

From some googling it looks like:

• Ubuntu 22.04.4 uses glibc 2.35
• CentOS stream 9 and 10 use 2.34
• CentOS stream 10 uses 2.39

[mhdawson]

When we build Node.js we use a toolset so that we can use later compilers which may need some functions in a later glibc so that we maintain compatibility with the older glibc levels as listed in https://github.com/nodejs/node/blob/main/BUILDING.md#platform-list

For addon's though its up to the addon developer to make sure that the required glibc levels are support by building with the right base system and compiler toolchains.

In the case above I would have expected builds on Centos 8 and 9 to work on Ubuntu 22.04.4 but not necessarily builds on Centos 10.

[mhdawson]

From the comment it looks like this container was being used to build - quay.io/pypa/manylinux2014_x86_64

[mhdawson]

I also see earlier on in the issue it says it is build on centos 7 - Build on CentOS Linux 7 (Core) which has glibc version 2.17

[mhdawson]

And more precisely CentOS Linux release 7.9.2009 based on the container.