MAINT: remove unreachable codepath. #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes conditional after a return statement.
|
Close/reopen to retrigger CI |
Codecov Report
@@ Coverage Diff @@
## master #272 +/- ##
==========================================
+ Coverage 93.15% 93.32% +0.16%
==========================================
Files 7 7
Lines 1257 1258 +1
==========================================
+ Hits 1171 1174 +3
+ Misses 86 84 -2 |
|
Looks fine to me too, in it goes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure what the wider context for this bit is (
git blamedidn't indicate that this was a mistake) but AFAICT this is unreachable code that is similar (but not identical) to the implementation in the base classNumpyDocString.