Space inside working directory's name

[toto975]

Q	A
Bug report?	yes
Feature request?	no
Library version	2.8

If the working directory has a space inside its name, there is this error :

  Syntax error

  at D:\Sites\working directory with space\vendor\nunomaduro\phpinsights\src\Domain\Insights\SyntaxCheck.php:56
     52▕             $process->setWorkingDirectory($this->collector->getCommonPath());
     53▕         }
     54▕         $process->run();
     55▕
  ➜  56▕         $output = json_decode($process->getOutput(), true, 512, JSON_THROW_ON_ERROR);
     57▕         $errors = $output['results']['errors'] ?? [];
     58▕
     59▕         foreach ($errors as $error) {
     60▕             if (preg_match('/^.*error:(.*) in .* on line [\d]+/m', $error['message'], $matches) === 1) {

  1   D:\Sites\working directory with space\vendor\nunomaduro\phpinsights\src\Domain\Insights\SyntaxCheck.php:56
      json_decode("")

  2   D:\Sites\working directory with space\vendor\nunomaduro\phpinsights\src\Domain\Runner.php:164
      NunoMaduro\PhpInsights\Domain\Insights\SyntaxCheck::process()

In phpinsights\src\Domain\Insights\SyntaxCheck.php, it can be fixed with

...
    public function process(): void
    {
        $toAnalyse = $this->getTarget();

        $cmdLine = sprintf(
            '"%s" --no-colors --no-progress --json %s %s', <==== add double quotes here with the the first %s
            $this->getBinary(),
            implode(' ', $this->getShellExcludeArgs()),
            $toAnalyse
        );
        $process = Process::fromShellCommandline($cmdLine);
...

[robw-raviga]

This is particularly relevant today with the release of Herd and it storing the PHP binaries in Users/.../Library/Application Support/Herd.

[ElRochito]

@robw-raviga @toto975
PR has been created on phpinsights #655 ! 👁️

[cmgmyr]

The fix is now in master. I'll be leaving it there for a few days before I tag a new release