nvm-exec doesn't exit when no version is set; doesn't suppress `use` output

[kl0tl]

Hi,

$ $NVM_DIR/nvm-exec node

and

$ $NVM_DIR/nvm-exec npm

cause an infinite loop when no .npmrc can be found.

I had a look but unfortunately my bash-fu is not that great. Any idea of what’s going on ?

[ljharb]

Neither cause that for me when I have no default, nvmrc, or npmrc - the first one opens a node REPL, so you need to be doing that on a TTY. Perhaps that's it?

[kl0tl]

Oh, that’s strange. I’m running the commands on the default OSX Terminal and I’m on Yosemite 10.10.3 if it can help.

[ljharb]

Per #998 i'm not really sure why you're calling nvm-exec directly anyways, especially without a version supplied.

[kl0tl]

Isn’t the purpose of those lines

if [ -n "$NODE_VERSION" ]; then
  nvm use $NODE_VERSION > /dev/null || (echo "NODE_VERSION not set" >&2 && exit 127)
else
  nvm use > /dev/null || (echo "No .nvmrc file found" >&2 && exit 127)
fi

to look for a version automatically ?

[ljharb]

yes, it's just not a common way to use nvm exec is all.

[kl0tl]

So why would I supply a version myself when it can be discovered automatically ?

[ljharb]

I meant nvm-exec versus nvm exec.

Since I can't reproduce the looping, I think this will need to be closed.

[kl0tl]

Have you a default alias for node ? It seems to prevent the bug to occur.

[kl0tl]

Here’s a video of the issue.

[ljharb]

I tried removing my default alias first before.

When I have an nvmrc and/or a default, it pops open the repl. When I don't, it prints out:

No .nvmrc file found
$NVM_DIR/nvm-exec: line 13: exec: node: not found

Perhaps it's invoking your node script which thus causes the infinite loop?

[kl0tl]

You’re right, it’s because of my script. I think I found the real issues tho, there’s two things:

• On my machine the output of nvm use is not suppressed. I made it work by redirecting only stderr to /dev/null.
• More importantly exit 127 doesn’t abort the script. I fixed it by guarding against this error code before exec.

It’s strange the former seems to work for you. The later would explain your exec: node: not found error and my infinite loop.

Would you accept some pull-requests to fix this ?

[ljharb]

I'd be happy to review the PRs (with tests) so that I can understand what you mean (nvm use is supposed to print output, unless you use --silent, and why would exit N not abort a script?)

[kl0tl]

On my machine nvm use prints the whole nvm --help output on error which is strange because it doesn’t seem to do it for you. I have no explanation for exit 127 not aborting the script but it’s not doing it. That’s why you get an error ($NVM_DIR/nvm-exec: line 13: exec: node: not found) and why it causes an infinite loop if you happen to have a node in your PATH that calls $NVM_DIR/nvm-exec node back.

I’ll submit the PRs over the week end !