Skip to content

@Entity(realClass: ) to support some custom code generators #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2021
Merged

@Entity(realClass: ) to support some custom code generators #255

merged 1 commit into from
Jun 13, 2021

Conversation

vaind
Copy link
Contributor

@vaind vaind commented May 26, 2021

closes #229

@vaind vaind requested a review from greenrobot-team May 26, 2021 19:39
@vaind vaind mentioned this pull request May 26, 2021
Closed
greenrobot-team
greenrobot-team reviewed May 31, 2021
View reviewed changes
Copy link
Member

@greenrobot-team greenrobot-team left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well as generated code.

It feels like this should have bad side-effects but couldn't think of any (e.g. renaming class should be fine).

@vaind vaind force-pushed the entity-real-class-annotation branch from cbd9009 to 6a137f1 Compare June 13, 2021 12:00
@vaind vaind merged commit f9080c5 into main Jun 13, 2021
@vaind vaind deleted the entity-real-class-annotation branch June 13, 2021 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greenrobot-team greenrobot-team greenrobot-team left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support freezed entities
2 participants
@vaind @greenrobot-team