non-strict window by default #993
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I agree this should be the default? Also the calling the option strict feels slightly better than extend? (Though maybe fixed would also work? I couldn’t find much precedent though the R runner package uses na_pad and defaults to non-strict).
Also the window transform was assuming that the input index is a typed array, but at least in the case of the map transform and a z channel, it may be a regular array. We still want to use subarray if available because it’s faster, and it’s probably not worth changing the map transform to generate Uint32Array, so I added a workaround in the window transform; I can take a different approach if you prefer.