generalize non-strict reducers #997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
commented
Jul 15, 2022
|
Ah, and another thing that we should change is that mode shouldn't coerce values to numbers. |
|
I fixed the mode problem in the latest commit. |
mbostock
commented
Jul 15, 2022
mbostock
commented
Jul 15, 2022
mbostock
added a commit
that referenced
this pull request
Jul 15, 2022
* skipNaN * generalize non-strict reducers (#997) * generalize non-strict reducers * tweak * don’t coerce for mode * non-strict reducers * DRY * mode can be undefined, not NaN * fix first/last defined logic * don’t coerce for first and last * numbers cannot be null * shorter * fix comment Co-authored-by: Philippe Rivière <[email protected]> * Update README * Update README * don’t coerce for min and max Co-authored-by: Mike Bostock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, this basically re-implements #990 from scratch again, but I think it makes sense. Several non-strict reducers (difference, ratio, first, and last) still need to be implemented: these will need to find the first defined and last defined values within the current window.