resolve jszip #238
Merged
resolve jszip #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
commented
Aug 1, 2021
| @@ -72,6 +78,17 @@ async function resolve(specifier) { | |||
| return { | |||
| name: package.name, | |||
| version: package.version, | |||
| export: (package.unpkg || package.jsdelivr || package.browser || package.main).replace(/^\.\//, "") | |||
| export: main(package) | |||
There was a problem hiding this comment.
This is a workaround for JSZip’s use of the nonstandard browser object for Browserify:
https://github.com/Stuk/jszip/blob/e5b3f0ddaa8182cd6ea253e97f678b9f36d0d8ac/package.json#L27-L30
I modeled this code after the same code from d3-require. Note that I just ended up hard-coding the main for JSZip (since I didn’t want to bother supporting Browserify-style entry parsing); this code is still needed so that the code doesn’t crash.
visnup
approved these changes
Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed this when rebasing #222. This also upgrades JSZip from 3.6.0 to 3.7.0 which you can see here:
Stuk/jszip@v3.6.0...e5b3f0d
The only change appears to be a security fix for weirdly-named files which I do not think applies in our usage.