-
Notifications
You must be signed in to change notification settings - Fork 84
add attributes to image() as options #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Mike Bostock <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style
should definitely be on the shortlist of attributes as well.
At this point, should we perhaps just accept and pass through any properties as attributes?
Ooh, yes, style is a good one. I am not sure we want to just pass through all properties, though. Would like to hear some thoughts from @mbostock on that. |
I agree we should make props an argument and then simply |
Reference #231
This doesn't address all of the image options, but starts by addressing the most common requests... width, height, alt and title.
Example: