Skip to content

Add SQL tag function and dialect property to SQLiteDatabaseClient #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2021
Merged

Add SQL tag function and dialect property to SQLiteDatabaseClient #268

merged 1 commit into from
Oct 28, 2021

Conversation

annie
Copy link
Contributor

@annie annie commented Oct 26, 2021

This change brings SQLiteDatabaseClient up to parity with the other DatabaseClient implementations in Observable.

Tested locally:

Screen Shot 2021-10-26 at 16 31 19

sydneypalumbo
sydneypalumbo approved these changes Oct 26, 2021
View reviewed changes
Copy link

@sydneypalumbo sydneypalumbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

@annie
Copy link
Contributor Author

annie commented Oct 26, 2021

TODO: bump version and publish!

@annie annie merged commit ed76e35 into main Oct 28, 2021
@annie annie deleted the annie/sqlite-update branch October 28, 2021 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydneypalumbo sydneypalumbo sydneypalumbo approved these changes

@mbostock mbostock Awaiting requested review from mbostock

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annie @sydneypalumbo