-
Notifications
You must be signed in to change notification settings - Fork 84
SQLiteDatabaseClient schema methods #283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Asking @visnup for another opinion here on how to pass through the raw database type. |
I like what's here plus a single key called maybe The only other thing worth considering is calling out bigint and date since the original JSON schema specification on ajv didn't provide for either. These were It seems since then there's JSON Type Definition which seems more promising?? And this more recent JSON Schema reference seems to document types for datetime. |
3357b35
to
5d56bed
Compare
I’ve populated the
We could probably fork sql.js to fix these issues. |
since this is a Table cell blocker, i think we should merge this once we've finalized the DatabaseClient schema API (based on Wiltse's PR) and updated this PR to match that specification (i've got a draft PR in the wings to make those updates). it seems reasonable to me to address the query results schema and date string issues as fast follows, if that sounds good? i can create separate issues for those! |
1cf6d2e
to
a93d445
Compare
a93d445
to
c8599fb
Compare
FYI, the describeColumns query had a syntax error which I fixed in d381b56. |
This implements the describeTables and describeColumns methods for SQLite.
Fixes #288.