Skip to content

Adopt ESM #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 10, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"extends": "eslint:recommended",
"parserOptions": {
"sourceType": "module",
"ecmaVersion": 2018
"ecmaVersion": 2020
},
"env": {
"es6": true,
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest]
node-version: [14.x, 16.x]
node-version: [14.x, 16.x, 18.x]

runs-on: ${{ matrix.os }}

Expand Down
2 changes: 1 addition & 1 deletion LICENSE
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Copyright 2018-2021 Observable, Inc.
Copyright 2018-2022 Observable, Inc.

Permission to use, copy, modify, and/or distribute this software for any purpose
with or without fee is hereby granted, provided that the above copyright notice
Expand Down
114 changes: 57 additions & 57 deletions README.md

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bin/resolve-dependencies
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const extensionRe = /\.[^/]*$/;
const mains = ["unpkg", "jsdelivr", "browser", "main"];

(async () => {
console.log(`import dependency from "./dependency.mjs";`);
console.log(`import dependency from "./dependency.js";`);
{
const package = await resolve("d3");
console.log(`export const d3 = dependency("${package.name}", "${package.version}", "${package.export}");`);
Expand Down
46 changes: 30 additions & 16 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,37 +1,51 @@
{
"name": "@observablehq/stdlib",
"version": "3.24.0",
"license": "ISC",
"main": "dist/stdlib.js",
"module": "src/index.mjs",
"version": "4.0.0-rc.1",
"author": {
"name": "Observable, Inc.",
"url": "https://observablehq.com"
},
"license": "ISC",
"type": "module",
"main": "src/index.js",
"module": "src/index.js",
"jsdelivr": "dist/stdlib.js",
"unpkg": "dist/stdlib.js",
"exports": {
"umd": "./dist/stdlib.js",
"default": "./src/index.js"
},
"repository": {
"type": "git",
"url": "https://github.com/observablehq/stdlib.git"
},
"files": [
"dist/**/*.js",
"src/**/*.js"
],
"engines": {
"node": ">=14.5.0"
},
"scripts": {
"test": "mocha 'test/**/*-test.mjs' && eslint src test --ext mjs",
"prepublishOnly": "rollup -c",
"test": "mocha 'test/**/*-test.js' && eslint src test",
"prepublishOnly": "rm -rf dist && rollup -c",
"postpublish": "git push && git push --tags"
},
"files": [
"src/**/*.mjs",
"dist/**/*.js"
],
"dependencies": {
"d3-dsv": "^2.0.0",
"d3-array": "^3.2.0",
"d3-dsv": "^3.0.1",
"d3-require": "^1.3.0"
},
"devDependencies": {
"@rollup/plugin-node-resolve": "^13.3.0",
"eslint": "^8.18.0",
"@rollup/plugin-node-resolve": "^15.0.1",
"eslint": "^8.27.0",
"exceljs": "^4.3.0",
"mocha": "^10.0.0",
"node-fetch": "^2.6.1",
"rollup": "^2.37.1",
"mocha": "^10.1.0",
"node-fetch": "^3.2.10",
"rollup": "^3.2.5",
"rollup-plugin-terser": "^7.0.2"
},
"publishConfig": {
"tag": "next"
}
}
4 changes: 2 additions & 2 deletions rollup.config.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import node from "@rollup/plugin-node-resolve";
import {terser} from "rollup-plugin-terser";
import * as meta from "./package.json";
import * as meta from "./package.json" assert {type: "json"};

const copyright = `// @observablehq/stdlib v${meta.version} Copyright ${(new Date).getFullYear()} Observable, Inc.`;

export default [
{
input: "src/index.mjs",
input: "src/index.js",
plugins: [
node(),
terser({
Expand Down
14 changes: 0 additions & 14 deletions src/array.mjs

This file was deleted.

2 changes: 1 addition & 1 deletion src/dependencies.mjs → src/dependencies.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import dependency from "./dependency.mjs";
import {dependency} from "./dependency.js";
export const d3 = dependency("d3", "7.6.1", "dist/d3.min.js");
export const inputs = dependency("@observablehq/inputs", "0.10.4", "dist/inputs.min.js");
export const plot = dependency("@observablehq/plot", "0.6.0", "dist/plot.umd.min.js");
Expand Down
2 changes: 1 addition & 1 deletion src/dependency.mjs → src/dependency.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
export default function dependency(name, version, main) {
export function dependency(name, version, main) {
return {
resolve(path = main) {
return `${name}@${version}/${path}`;
Expand Down
2 changes: 1 addition & 1 deletion src/dom/canvas.mjs → src/dom/canvas.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
export default function(width, height) {
export function canvas(width, height) {
var canvas = document.createElement("canvas");
canvas.width = width;
canvas.height = height;
Expand Down
2 changes: 1 addition & 1 deletion src/dom/context2d.mjs → src/dom/context2d.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
export default function(width, height, dpi) {
export function context2d(width, height, dpi) {
if (dpi == null) dpi = devicePixelRatio;
var canvas = document.createElement("canvas");
canvas.width = width * dpi;
Expand Down
2 changes: 1 addition & 1 deletion src/dom/download.mjs → src/dom/download.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
export default function(value, name = "untitled", label = "Save") {
export function download(value, name = "untitled", label = "Save") {
const a = document.createElement("a");
const b = a.appendChild(document.createElement("button"));
b.textContent = label;
Expand Down
2 changes: 1 addition & 1 deletion src/dom/element.mjs → src/dom/element.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ var namespaces = {
xmlns: "http://www.w3.org/2000/xmlns/"
};

export default function(name, attributes) {
export function element(name, attributes) {
var prefix = name += "", i = prefix.indexOf(":"), value;
if (i >= 0 && (prefix = name.slice(0, i)) !== "xmlns") name = name.slice(i + 1);
var element = namespaces.hasOwnProperty(prefix) // eslint-disable-line no-prototype-builtins
Expand Down
10 changes: 10 additions & 0 deletions src/dom/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
export {canvas} from "./canvas.js";
export {context2d} from "./context2d.js";
export {download} from "./download.js";
export {element} from "./element.js";
export {input} from "./input.js";
export {range} from "./range.js";
export {select} from "./select.js";
export {svg} from "./svg.js";
export {text} from "./text.js";
export {uid} from "./uid.js";
23 changes: 0 additions & 23 deletions src/dom/index.mjs

This file was deleted.

2 changes: 1 addition & 1 deletion src/dom/input.mjs → src/dom/input.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
export default function(type) {
export function input(type) {
var input = document.createElement("input");
if (type != null) input.type = type;
return input;
Expand Down
2 changes: 1 addition & 1 deletion src/dom/range.mjs → src/dom/range.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
export default function(min, max, step) {
export function range(min, max, step) {
if (arguments.length === 1) max = min, min = null;
var input = document.createElement("input");
input.min = min = min == null ? 0 : +min;
Expand Down
2 changes: 1 addition & 1 deletion src/dom/select.mjs → src/dom/select.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
export default function(values) {
export function select(values) {
var select = document.createElement("select");
Array.prototype.forEach.call(values, function(value) {
var option = document.createElement("option");
Expand Down
2 changes: 1 addition & 1 deletion src/dom/svg.mjs → src/dom/svg.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
export default function(width, height) {
export function svg(width, height) {
var svg = document.createElementNS("http://www.w3.org/2000/svg", "svg");
svg.setAttribute("viewBox", [0, 0, width, height]);
svg.setAttribute("width", width);
Expand Down
2 changes: 1 addition & 1 deletion src/dom/text.mjs → src/dom/text.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
export default function(value) {
export function text(value) {
return document.createTextNode(value);
}
2 changes: 1 addition & 1 deletion src/dom/uid.mjs → src/dom/uid.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
var count = 0;

export default function(name) {
export function uid(name) {
return new Id("O-" + (name == null ? "" : name + "-") + ++count);
}

Expand Down
10 changes: 5 additions & 5 deletions src/fileAttachment.mjs → src/fileAttachment.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import {autoType, csvParse, csvParseRows, tsvParse, tsvParseRows} from "d3-dsv";
import {arrow, jszip, exceljs} from "./dependencies.mjs";
import {requireDefault} from "./require.mjs";
import {SQLiteDatabaseClient} from "./sqlite.mjs";
import {Workbook} from "./xlsx.mjs";
import {arrow, jszip, exceljs} from "./dependencies.js";
import {requireDefault} from "./require.js";
import {SQLiteDatabaseClient} from "./sqlite.js";
import {Workbook} from "./xlsx.js";

async function remote_fetch(file) {
const response = await fetch(await file.url());
Expand Down Expand Up @@ -93,7 +93,7 @@ export function NoFileAttachments(name) {
throw new Error(`File not found: ${name}`);
}

export default function FileAttachments(resolve) {
export function FileAttachments(resolve) {
return Object.assign(
name => {
const result = resolve(name += "");
Expand Down
2 changes: 1 addition & 1 deletion src/files/buffer.mjs → src/files/buffer.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
export default function(file) {
export function buffer(file) {
return new Promise(function(resolve, reject) {
var reader = new FileReader;
reader.onload = function() { resolve(reader.result); };
Expand Down
3 changes: 3 additions & 0 deletions src/files/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
export {buffer} from "./buffer.js";
export {text} from "./text.js";
export {url} from "./url.js";
9 changes: 0 additions & 9 deletions src/files/index.mjs

This file was deleted.

2 changes: 1 addition & 1 deletion src/files/text.mjs → src/files/text.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
export default function(file) {
export function text(file) {
return new Promise(function(resolve, reject) {
var reader = new FileReader;
reader.onload = function() { resolve(reader.result); };
Expand Down
2 changes: 1 addition & 1 deletion src/files/url.mjs → src/files/url.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
export default function(file) {
export function url(file) {
return new Promise(function(resolve, reject) {
var reader = new FileReader;
reader.onload = function() { resolve(reader.result); };
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import that from "../that.mjs";
import {that} from "../that.js";

export default function disposable(value, dispose) {
export function disposable(value, dispose) {
let done = false;
if (typeof dispose !== "function") {
throw new Error("dispose is not a function");
Expand Down
2 changes: 1 addition & 1 deletion src/generators/filter.mjs → src/generators/filter.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
export default function*(iterator, test) {
export function* filter(iterator, test) {
var result, index = -1;
while (!(result = iterator.next()).done) {
if (test(result.value, ++index)) {
Expand Down
9 changes: 9 additions & 0 deletions src/generators/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
export {disposable} from "./disposable.js";
export {filter} from "./filter.js";
export {input} from "./input.js";
export {map} from "./map.js";
export {observe} from "./observe.js";
export {queue} from "./queue.js";
export {range} from "./range.js";
export {valueAt} from "./valueAt.js";
export {worker} from "./worker.js";
21 changes: 0 additions & 21 deletions src/generators/index.mjs

This file was deleted.

4 changes: 2 additions & 2 deletions src/generators/input.mjs → src/generators/input.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import observe from "./observe.mjs";
import {observe} from "./observe.js";

export default function(input) {
export function input(input) {
return observe(function(change) {
var event = eventof(input), value = valueof(input);
function inputted() { change(valueof(input)); }
Expand Down
2 changes: 1 addition & 1 deletion src/generators/map.mjs → src/generators/map.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
export default function*(iterator, transform) {
export function* map(iterator, transform) {
var result, index = -1;
while (!(result = iterator.next()).done) {
yield transform(result.value, ++index);
Expand Down
4 changes: 2 additions & 2 deletions src/generators/observe.mjs → src/generators/observe.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import that from "../that.mjs";
import {that} from "../that.js";

export default function(initialize) {
export function observe(initialize) {
let stale = false;
let value;
let resolve;
Expand Down
4 changes: 2 additions & 2 deletions src/generators/queue.mjs → src/generators/queue.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import that from "../that.mjs";
import {that} from "../that.js";

export default function(initialize) {
export function queue(initialize) {
let resolve;
const queue = [];
const dispose = initialize(push);
Expand Down
2 changes: 1 addition & 1 deletion src/generators/range.mjs → src/generators/range.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
export default function*(start, stop, step) {
export function* range(start, stop, step) {
start = +start;
stop = +stop;
step = (n = arguments.length) < 2 ? (stop = start, start = 0, 1) : n < 3 ? 1 : +step;
Expand Down
2 changes: 1 addition & 1 deletion src/generators/valueAt.mjs → src/generators/valueAt.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
export default function(iterator, i) {
export function valueAt(iterator, i) {
if (!isFinite(i = +i) || i < 0 || i !== i | 0) return;
var result, index = -1;
while (!(result = iterator.next()).done) {
Expand Down
4 changes: 2 additions & 2 deletions src/generators/worker.mjs → src/generators/worker.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import disposable from "./disposable.mjs";
import {disposable} from "./disposable.js";

export default function worker(source) {
export function worker(source) {
const url = URL.createObjectURL(new Blob([source], {type: "text/javascript"}));
const worker = new Worker(url);
return disposable(worker, () => {
Expand Down
Loading