Skip to content

[email protected] depends on arrow11 #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2023
Merged

[email protected] depends on arrow11 #359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions bin/resolve-dependencies.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,10 @@ const mains = ["unpkg", "jsdelivr", "browser", "main"];
const info = await resolve("apache-arrow@9");
console.log(`export const arrow9 = dependency("${info.name}", "${info.version}", "+esm");`);
}
{
const info = await resolve("apache-arrow@11");
console.log(`export const arrow11 = dependency("${info.name}", "${info.version}", "+esm");`);
}
{
const info = await resolve("arquero");
console.log(`export const arquero = dependency("${info.name}", "${info.version}", "${info.export}");`);
Expand Down
2 changes: 1 addition & 1 deletion src/arrow.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {arrow9 as arrow} from "./dependencies.js";
import {arrow11 as arrow} from "./dependencies.js";
import {cdn} from "./require.js";

// Returns true if the vaue is an Apache Arrow table. This uses a “duck” test
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Returns true if the vaue is an Apache Arrow table. This uses a “duck” test
// Returns true if the value is an Apache Arrow table. This uses a “duck” test

Expand Down
1 change: 1 addition & 0 deletions src/dependencies.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ export const vegalite = dependency("vega-lite", "5.6.0", "build/vega-lite.min.js
export const vegaliteApi = dependency("vega-lite-api", "5.0.0", "build/vega-lite-api.min.js");
export const arrow4 = dependency("apache-arrow", "4.0.1", "Arrow.es2015.min.js");
export const arrow9 = dependency("apache-arrow", "9.0.0", "+esm");
export const arrow11 = dependency("apache-arrow", "11.0.0", "+esm");
export const arquero = dependency("arquero", "4.8.8", "dist/arquero.min.js");
export const topojson = dependency("topojson-client", "3.1.0", "dist/topojson-client.min.js");
export const exceljs = dependency("exceljs", "4.3.0", "dist/exceljs.min.js");
Expand Down
6 changes: 5 additions & 1 deletion src/fileAttachment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {autoType, csvParse, csvParseRows, tsvParse, tsvParseRows} from "d3-dsv";
import {arrow4, arrow9, jszip, exceljs} from "./dependencies.js";
import {arrow4, arrow9, arrow11, jszip, exceljs} from "./dependencies.js";
import {cdn, requireDefault} from "./require.js";
import {SQLiteDatabaseClient} from "./sqlite.js";
import {Workbook} from "./xlsx.js";
Expand Down Expand Up @@ -66,6 +66,10 @@ export class AbstractFile {
const [Arrow, response] = await Promise.all([import(`${cdn}${arrow9.resolve()}`), remote_fetch(this)]);
return Arrow.tableFromIPC(response);
}
case 11: {
const [Arrow, response] = await Promise.all([import(`${cdn}${arrow11.resolve()}`), remote_fetch(this)]);
return Arrow.tableFromIPC(response);
}
default: throw new Error(`unsupported arrow version: ${version}`);
}
}
Expand Down