Skip to content

[IMP] website: update building blocks #13568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

masp-odoo
Copy link
Contributor

taskid-4644908

@robodoo
Copy link
Collaborator

robodoo commented May 27, 2025

Pull request status dashboard

@masp-odoo masp-odoo force-pushed the 18.0-website-building-blocks-masp branch from 4a4f1ff to 4ebefb4 Compare May 27, 2025 13:57
@masp-odoo masp-odoo force-pushed the 18.0-website-building-blocks-masp branch from 4ebefb4 to 4231081 Compare June 12, 2025 13:30
@masp-odoo masp-odoo force-pushed the 18.0-website-building-blocks-masp branch 2 times, most recently from cb4b8ff to 2a2a5f6 Compare June 23, 2025 09:21
@masp-odoo masp-odoo marked this pull request as ready for review June 23, 2025 09:23
@masp-odoo masp-odoo requested a review from auva-odoo June 23, 2025 09:23
@masp-odoo
Copy link
Contributor Author

Hi @auva-odoo, could you please review this? We can also discuss this anytime, thank you so much!

@C3POdoo C3POdoo requested a review from a team June 23, 2025 09:25
@masp-odoo masp-odoo force-pushed the 18.0-website-building-blocks-masp branch from 2a2a5f6 to 0fba09a Compare June 23, 2025 09:30
Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear @masp-odoo, thank you for this PR!! I know it wasn't easy to reorganize the information and clean up so much content but I think you did a really good job overall!

I added a few comments in suggestions in my review (some we probably need to discuss IRL). In addition:

  • Don't forget to resolve the conflict in the redirect file.
  • Structure-wise: I think I would restructure the page a bit so things flow a bit more logically (to me at least?). For example, I would move the content of the "Inner content" + "Dynamic content" sections (to the "Add a building block" section (as sub-sections) and then the "Color" and "Layout" sections as sub-sections of the "Edit a building block" section. We can discuss this of course, it's just a suggestion! But I do think we can move things around a bit.
    The structure would then look like this (see my individual comments as well for more info, I changed this screenshot several times 😅 )
    image
  • FYI, you could use the :scale: option to adapt the size of some screenshots if necessary (altough you will see I did suggest to get rid of a lot of screenshots)
  • Could you please add the app name in the anchor names? Like this: app name/file name/anchor name
  • Don't forget to add a descriptor for the icon names. I added a few comments here and there but I probably missed some, could you please check the whole doc?

Thank you again for your work! 🙏

@masp-odoo masp-odoo force-pushed the 18.0-website-building-blocks-masp branch 2 times, most recently from a4797d7 to 7a9dbdc Compare July 1, 2025 09:45
@masp-odoo
Copy link
Contributor Author

Hello again @auva-odoo, could you please review the changes ? Thanks a looooot!

@C3POdoo C3POdoo requested a review from a team July 1, 2025 10:14
@masp-odoo masp-odoo requested a review from auva-odoo July 1, 2025 10:45
@masp-odoo masp-odoo force-pushed the 18.0-website-building-blocks-masp branch 2 times, most recently from 9bfbc21 to aff7bd0 Compare July 1, 2025 10:54
@auva-odoo auva-odoo force-pushed the 18.0-website-building-blocks-masp branch from aff7bd0 to e549380 Compare July 2, 2025 08:44
@C3POdoo C3POdoo requested review from a team July 2, 2025 08:48
@auva-odoo auva-odoo force-pushed the 18.0-website-building-blocks-masp branch from e549380 to bbeae93 Compare July 2, 2025 08:52
@auva-odoo auva-odoo removed request for a team July 2, 2025 08:54
@auva-odoo auva-odoo force-pushed the 18.0-website-building-blocks-masp branch from bbeae93 to 7d0313b Compare July 2, 2025 09:16
Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your hard work @masp-odoo 💪 🙏 I force-pushed the changes we discussed 😉

@robodoo r+

@masp-odoo
Copy link
Contributor Author

Thank YOU @auva-odoo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants