Value printing refactor (pretty print structs) #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
force-pushed
the
value_printing_refactor
branch
from
4510f13 to
3d1b057
Compare
|
Blocked on rust-lang/rust#51471 |
oli-obk
reviewed
Jun 10, 2018
src/render/locals.rs
Outdated
| Ok(format!("{0}", bits)) | ||
| } | ||
| TypeVariants::TyInt(_) => { | ||
| Ok(format!("{0}", bits as i128)) |
There was a problem hiding this comment.
this should not work for i64 and smaller. You need to sign extend first
src/render/locals.rs
Outdated
| }; | ||
| pretty.push_str(&format!("{}: {}, ", adt_field.ident.as_str(), match field_pretty { | ||
| Ok(field_pretty) => field_pretty, | ||
| Err(_err) => "<span style='color: red;'><err></span>".to_string(), |
There was a problem hiding this comment.
when does this case occur? if the memory is malformed?
There was a problem hiding this comment.
Yes, or not yet initialized.
bjorn3
force-pushed
the
value_printing_refactor
branch
from
c58b6d9 to
84dcc83
Compare
bjorn3
force-pushed
the
value_printing_refactor
branch
2 times, most recently
from
6ded07d to
f2824ca
Compare
bjorn3
force-pushed
the
value_printing_refactor
branch
from
24df9f8 to
ade59db
Compare
|
This works for enums now:
|
|
Sweet, this makes reading the local table so much better. For larger structs we might want to wrap it in a |
bjorn3
force-pushed
the
value_printing_refactor
branch
from
8d0cf9e to
4864e90
Compare
Done
Build is failing due to broken miri. |
bjorn3
force-pushed
the
value_printing_refactor
branch
from
4864e90 to
f5de0e6
Compare
bjorn3
changed the title
bjorn3
force-pushed
the
value_printing_refactor
branch
from
9127c24 to
cf59695
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
Value