Skip to content

Collect attributes from interfaces and traits #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025

Conversation

olvlvl
Copy link
Owner

@olvlvl olvlvl commented Jun 17, 2025

Attributes are now collected from interfaces and traits as well as classes, allowing the following kind of setup:

#[AutowiredService(factory: '@PHPStan\Reflection\SignatureMap\SignatureMapProviderFactory::create')]
interface SignatureMapProvider
{
    // ...

@olvlvl olvlvl added the enhancement New feature or request label Jun 17, 2025
@olvlvl olvlvl added this to the v2.1.0 milestone Jun 17, 2025
@olvlvl olvlvl self-assigned this Jun 17, 2025
@olvlvl olvlvl force-pushed the main-collect-interfaces branch from 0661dde to 8c20d0a Compare June 17, 2025 08:44
@olvlvl olvlvl merged commit d8f26b0 into main Jun 17, 2025
13 checks passed
@olvlvl olvlvl deleted the main-collect-interfaces branch June 17, 2025 08:47
@coveralls
Copy link

Pull Request Test Coverage Report for Build 15702413547

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-1.1%) to 91.094%

Files with Coverage Reduction New Missed Lines %
src/MemoizeAttributeCollector.php 4 85.37%
Totals Coverage Status
Change from base Build 15580897263: -1.1%
Covered Lines: 358
Relevant Lines: 393

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 15702509679

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-1.1%) to 91.094%

Files with Coverage Reduction New Missed Lines %
src/MemoizeAttributeCollector.php 4 85.37%
Totals Coverage Status
Change from base Build 15580897263: -1.1%
Covered Lines: 358
Relevant Lines: 393

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants