[L0] Fix the multi device event cache to allocate lists as pointers #1366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nrspruit
commented
Feb 21, 2024
nrspruit
commented
- fix to address a multi device crash given many devices causing a stack overflow. Event Caches per device are now explicitly allocated.
nrspruit
force-pushed
the
fix_multidevice_event_cache
branch
from
8cb63cc to
ac235a6
Compare
nrspruit
force-pushed
the
fix_multidevice_event_cache
branch
from
ac235a6 to
486ee85
Compare
raiyanla
approved these changes
Feb 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1366 +/- ##
==========================================
- Coverage 14.82% 12.72% -2.11%
==========================================
Files 250 238 -12
Lines 36220 35354 -866
Branches 4094 4011 -83
==========================================
- Hits 5369 4498 -871
- Misses 30800 30852 +52
+ Partials 51 4 -47 ☔ View full report in Codecov by Sentry. |
|
The OpenCL and Natuve CPU runner has died. Since this only touches the Level Zero adapter we can merge this without those jobs running. However there is a regression in the intel/llvm testing which will need to be resolved https://github.com/intel/llvm/actions/runs/7983767351/job/21814442025?pr=12778 |
kbenzie
reviewed
Feb 21, 2024
nrspruit
force-pushed
the
fix_multidevice_event_cache
branch
from
486ee85 to
dbafafa
Compare
- fix to address a multi device crash given many devices causing a stack overflow. Event Caches per device are now explicitly allocated. Signed-off-by: Spruit, Neil R <[email protected]>
nrspruit
force-pushed
the
fix_multidevice_event_cache
branch
from
dbafafa to
123c00f
Compare
nrspruit
added a commit
to nrspruit/llvm
that referenced
this pull request
Feb 21, 2024
- fix to address a multi device crash given many devices causing a stack overflow. Event Caches per device are now explicitly allocated. - pre-commit PR for oneapi-src/unified-runtime#1366 Signed-off-by: Spruit, Neil R <[email protected]>
kbenzie
added a commit
that referenced
this pull request
Feb 22, 2024
[L0] Fix the multi device event cache to allocate lists as pointers
2 tasks
steffenlarsen
pushed a commit
to intel/llvm
that referenced
this pull request
Feb 22, 2024
…rs (#12778) - fix to address a multi device crash given many devices causing a stack overflow. Event Caches per device are now explicitly allocated. - pre-commit PR for oneapi-src/unified-runtime#1366 --------- Signed-off-by: Spruit, Neil R <[email protected]> Co-authored-by: Kenneth Benzie (Benie) <[email protected]>
pbalcer
added a commit
to pbalcer/unified-runtime
that referenced
this pull request
Feb 28, 2024
…ice_event_cache" This reverts commit 6863ca7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.