Enable (almost) all conformance test on PVC for L0 #2223
Conversation
github-actions
bot
added
ci/cd
| GTEST_FAIL() << "AMD and Nvidia can't check kernel arguments."; | ||
| backend == UR_PLATFORM_BACKEND_HIP || | ||
| backend == UR_PLATFORM_BACKEND_LEVEL_ZERO) { | ||
| GTEST_FAIL() << "AMD, L0 and Nvidia can't check kernel arguments."; |
There was a problem hiding this comment.
sooo... this is a native cpu adapter test then?:D
There was a problem hiding this comment.
Yeah, I guess. Tbh, I don't know if there are any plans to add support for that for other backends.
igchor
changed the title
igchor
force-pushed
the
enqueue_usm
branch
8 times, most recently
from
4571524 to
76ee4d0
Compare
|
There are a few new test failures (random) for the legacy L0 adapter after recent in cts_exe (most likely a driver issue). I'm wondering if we should add some matches for a specific devices (PVC)? |
Yeah, generally if a feature is unsupported the test should skip the test, not fail. This should take care of expected platform differences. However, if there are some bugs that occur only on one platform, then yes, we should add matches with |
Fix urEnqueueKernelLaunchUSMLinkedList by providing required alignment and calling urKernelSetExecInfo. Also, skip InvalidKernelArgs for L0 as L0 cannot check kernel arguments.
and return appropriate error from urKernelSetArgValue
Done. |
and implement it for L0 v2
it does not work with multiple devices.
Fix urEnqueueKernelLaunchUSMLinkedList by providing required alignment and calling urKernelSetExecInfo.
Also, skip InvalidKernelArgs for L0 as L0
cannot check kernel arguments.