Move nightly CI tests to the main branch #844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbalcer
approved these changes
Sep 1, 2023
lukaszstolarczuk
approved these changes
Sep 1, 2023
There was a problem hiding this comment.
This is a little "heh", as we discussed (if we introduce any change in fuzzing tests execution on adapters branch, this workflow should be updated on a sep. PR to the main branch), but it looks clean and hopefully will work :)
Please remove after that the nightly.yml from the adapters branch, I guess.
|
@PatKamin, actually, did you test this on your fork (e.g., on |
Turned the PR to draft until I verify on my fork with cron schedule. |
Fuzz tests set up with cron don't run because cron scheduled workflows are triggered only for the default branch. Add nightly workflow file to the default branch with fuzz tests specified to run on 'adapters' branch.
PatKamin
force-pushed
the
fix-nightly-tests
branch
from
bace348 to
fd93ee0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fuzz tests set up with cron don't run because cron scheduled workflows are triggered only for the default branch.
Add nightly workflow file to the default branch with fuzz tests specified to run on 'adapters' branch.