Skip to content

Improve test suite #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 14, 2024
Merged

Improve test suite #4

merged 10 commits into from
Mar 14, 2024

Conversation

pascalbaljet
Copy link
Contributor

@pascalbaljet pascalbaljet commented Mar 14, 2024 •
edited
Loading

  • Added GitHub Actions workflow
  • Bumped saloonphp/laravel-http-sender dependency to support Laravel 11
  • Bumped Laravel 10 requirement to ^10.32 as it requires getGlobalMiddleware()
  • Removed unneeded guzzlehttp/guzzle dependency
  • Streamlined EventServiceProvider into ServiceProvider
  • Added tests for EventHelper, PendingRequestMixin and ServiceProvider
  • The added Guzzle middleware now has a name for easier debugging and testing

@pascalbaljet pascalbaljet marked this pull request as ready for review March 14, 2024 09:39
onlime
onlime requested changes Mar 14, 2024
View reviewed changes
Copy link
Owner

@onlime onlime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great PR! 👏 Thanks @pascalbaljet
just needs one small refinement...

@onlime onlime merged commit d5697e2 into onlime:main Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onlime onlime onlime requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pascalbaljet @onlime