L0: switch to zesInit() #695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 8, 2024
L0 osdevs may have subdevices, hence the PCI parent isn't always the first parent. Signed-off-by: Brice Goglin <[email protected]>
Signed-off-by: Brice Goglin <[email protected]>
They are the same for now because we use the legacy way to enable Sysman, which allows to cast between handles, but it won't be the case anymore soon. By the way, clear an array on error to help coverity. Signed-off-by: Brice Goglin <[email protected]>
zesDriverGetDeviceByUuidExp() will be mandatory in the next commits. Now we assume zesInit() exists (and works) since it was added way earlier than zesDriverGetDeviceByUuidExp() Signed-off-by: Brice Goglin <[email protected]>
Instead of casting from ZE handles. Disable tests/hwloc/levelzero for now since the core library is still transitioning to zesInit(), and helpers haven't been updated yet. Signed-off-by: Brice Goglin <[email protected]>
Just rely on zesInit() being supported (because we use features added later). Remove the constructor that was setting ZES_ENABLE_SYSMAN=1 in the environment. tests/hwloc/levelzero.c is updated too, but still disabled until helpers are updated. Signed-off-by: Brice Goglin <[email protected]>
We cannot use the same handle for ZE/Core and ZES/Sysman APIs anymore, so split the helpers in levelzero.h into normal and sysman functions, and update tests to check both. Reenable tests/hwloc/levelzero.c and update it to test both ZE and ZES APIs. By the way, cleanup random things and clarify some docs. Signed-off-by: Brice Goglin <[email protected]>
BTW, when I tests it was on a PVC Thanks a lot! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still needs to be tested on a machine with subdevices (PVC), but I don't have any such machine with a recent-enough L0 implementation.