Release 5.0.4 failed to build on GitHub Actions macOS 14.5 arm64

[dalcinl]

Thank you for taking the time to submit an issue!

Background information

What version of Open MPI are you using? (e.g., v4.1.6, v5.0.1, git branch name and hash, etc.)

5.0.4

Describe how Open MPI was installed (e.g., from a source/distribution tarball, from a git clone, from an operating system distribution package, etc.)

https://github.com/mpi4py/mpi-publish/blob/master/cibw-build-mpi.sh

Please describe the system on which you are running

• Operating system/version: macOS 14.5
• Computer hardware: Apple Silicon (arm64)
• Network type: local, shm

---

Details of the problem

Full build logs: https://github.com/mpi4py/mpi-publish/actions/runs/9996695568/job/27631626010

...
2024-07-18T18:29:14.8093900Z /Users/runner/work/mpi-publish/mpi-publish/package/source/ompi/mca/op/aarch64/op_aarch64_functions.c:165:5: error: pasting formed 'int8##', an invalid preprocessing token
2024-07-18T18:29:14.8094720Z     OP_AARCH64_FUNC(max, s,  8, 16,   int, max)
2024-07-18T18:29:14.8094980Z     ^
2024-07-18T18:29:14.8095850Z /Users/runner/work/mpi-publish/mpi-publish/package/source/ompi/mca/op/aarch64/op_aarch64_functions.c:122:56: note: expanded from macro 'OP_AARCH64_FUNC'
2024-07-18T18:29:14.8096730Z         OP_CONCAT(OMPI_OP_TYPE_PREPEND, type##type_size####x##type_cnt##_t) vsrc, vdst;       \
2024-07-18T18:29:14.8097160Z                                                        ^
2024-07-18T18:29:14.8097920Z /Users/runner/work/mpi-publish/mpi-publish/package/source/ompi/mca/op/aarch64/op_aarch64_functions.c:165:5: error: use of undeclared identifier 'int8'
2024-07-18T18:29:14.8099220Z /Users/runner/work/mpi-publish/mpi-publish/package/source/ompi/mca/op/aarch64/op_aarch64_functions.c:122:41: note: expanded from macro 'OP_AARCH64_FUNC'
2024-07-18T18:29:14.8100050Z         OP_CONCAT(OMPI_OP_TYPE_PREPEND, type##type_size####x##type_cnt##_t) vsrc, vdst;       \
2024-07-18T18:29:14.8100450Z                                         ^
2024-07-18T18:29:14.8100720Z <scratch space>:133:1: note: expanded from here
2024-07-18T18:29:14.8100980Z int8
2024-07-18T18:29:14.8101110Z ^
2024-07-18T18:29:14.8101750Z /Users/runner/work/mpi-publish/mpi-publish/package/source/ompi/mca/op/aarch64/op_aarch64_functions.c:165:5: error: use of undeclared identifier 'vsrc'
2024-07-18T18:29:14.8102920Z /Users/runner/work/mpi-publish/mpi-publish/package/source/ompi/mca/op/aarch64/op_aarch64_functions.c:124:13: note: expanded from macro 'OP_AARCH64_FUNC'
2024-07-18T18:29:14.8103710Z             vsrc = vld1q##_##type_name##type_size(in);                                        \
2024-07-18T18:29:14.8104060Z             ^
2024-07-18T18:29:14.8104710Z /Users/runner/work/mpi-publish/mpi-publish/package/source/ompi/mca/op/aarch64/op_aarch64_functions.c:165:5: error: use of undeclared identifier 'vdst'
2024-07-18T18:29:14.8105880Z /Users/runner/work/mpi-publish/mpi-publish/package/source/ompi/mca/op/aarch64/op_aarch64_functions.c:125:13: note: expanded from macro 'OP_AARCH64_FUNC'
2024-07-18T18:29:14.8106670Z             vdst = vld1q##_##type_name##type_size(out);                                       \
2024-07-18T18:29:14.8107020Z             ^
2024-07-18T18:29:14.8107670Z /Users/runner/work/mpi-publish/mpi-publish/package/source/ompi/mca/op/aarch64/op_aarch64_functions.c:165:5: error: use of undeclared identifier 'vdst'
2024-07-18T18:29:14.8108800Z /Users/runner/work/mpi-publish/mpi-publish/package/source/ompi/mca/op/aarch64/op_aarch64_functions.c:127:13: note: expanded from macro 'OP_AARCH64_FUNC'
2024-07-18T18:29:14.8109600Z             vdst = OP_CONCAT(OMPI_OP_OP_PREPEND, op##q##_##type_name##type_size)(vdst, vsrc); \
2024-07-18T18:29:14.8109980Z             ^
2024-07-18T18:29:14.8111300Z /Users/runner/work/mpi-publish/mpi-publish/package/source/ompi/mca/op/aarch64/op_aarch64_functions.c:165:5: error: use of undeclared identifier 'vdst'
2024-07-18T18:29:14.8112500Z /Users/runner/work/mpi-publish/mpi-publish/package/source/ompi/mca/op/aarch64/op_aarch64_functions.c:127:82: note: expanded from macro 'OP_AARCH64_FUNC'
2024-07-18T18:29:14.8113330Z             vdst = OP_CONCAT(OMPI_OP_OP_PREPEND, op##q##_##type_name##type_size)(vdst, vsrc); 
...

[bosilca]

The 5.x is missing 7c5ef48

[wenduwan]

Backport #12694

[wenduwan]

Fix merged. Will be included for the next release.

But this bug is annoying - recently we had a few snags on MacOS. I wonder if/how we should increase our CI coverage for MacOS(x86 + arm).

[jsquyres]

@wenduwan Does this mean a 5.0.5 in the immediate future?

[wenduwan]

@jsquyres I'm not sure. We are currently targeting 10/18. There are other critical bugfixes as well, and we can do another release once we get them in.

[jsquyres]

The 4.1 is missing 7c5ef48

@bosilca I don't think this commit is relevant to the v4.1.x branch -- am I missing something?

[bosilca]

My comment was incorrect, I was talking about the 5.x. Let me go and fix it.

[jsquyres]

squyres I'm not sure. We are currently targeting 10/18. There are other critical bugfixes as well, and we can do another release once we get them in.

@wenduwan 5.0.4 fails to build on MacOS out of the box. Doesn't that qualify as an "oh crap!" and mandate an immediate 5.0.5?

[wenduwan]

@jsquyres I need guidance for this. It's a build failure, meaning packagers (MacOS + ARM) are affected; on the other hand, end users won't be affected, i.e. no runtime error. Do we consider this to warrant an immediate release?

[wenduwan]

I also want to hear from @dalcinl what is the impact to you and your user base?

[rhc54]

Well, building on my Mac/M2, I see the following warnings that I don't grok (may be some missing lines as I only keep the stderr output):

configure: WARNING: -g has been added to CFLAGS (--enable-debug)
configure: WARNING: Could not find pmixcc
configure: WARNING: Your PMIx version is either does not
configure: WARNING: the capabilities feature or does not
configure: WARNING: include the PMIX_CAP_BASE capability flag
configure: WARNING: Ignoring this for now
...
configure: WARNING: UCX version is too old, please upgrade to 1.9 or higher.

There is also a flood of warnings out of OMPI itself, but I'll ignore those for now. However, it [edit: shouldn't have said "built just fine" given all the warnings] "successfully built", so I suspect the failure involves some specific set of aux libraries that activate components, or something else specific to the environment.