Skip to content

More runpath/rpath docs updates #10652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 15, 2022

Conversation

jsquyres
Copy link
Member

@jsquyres jsquyres commented Aug 12, 2022

This is a follow-on PR to #10624 with suggestions from @Reuti and @haampie.

NOTE: This PR is about documenting current wrapper rpath/runpath behavior. @haampie raises some good points in #10560, but I'd rather address those separately (i.e., if we change the behavior of configure and the wrappers, we should update the docs to match).

I also extracted the docs-specific part of the otherwise-controversial #10398: I have no objections to fixing the trailing whitespace we accidentally put in the RST-ified man pages. Thanks to @a-szegel.

a-szegel and others added 3 commits August 11, 2022 20:29
Removes trailing whitespace from files in the docs directory.

Signed-off-by: Seth Zegelstein <[email protected]>
Signed-off-by: Jeff Squyres <[email protected]>
Thanks to Thomas Reuter for pointing out the issue.

Signed-off-by: Jeff Squyres <[email protected]>
Thanks to feedback from Thomas Reuter and Harmen Stoppels.

Signed-off-by: Jeff Squyres <[email protected]>
@jsquyres
Copy link
Member Author

@Reuti @haampie Got any opinions on this before I merge? Again, the goal is to document the current behavior. Let's iterate on #10560 (comment) to decide on new behavior.

@jsquyres jsquyres merged commit ff79994 into open-mpi:main Aug 15, 2022
@jsquyres jsquyres deleted the pr/moar-runpath-rpath-docs-updates branch August 15, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants