PML/SPML/UCX: init global objects using C99 style #5480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- to avoid value mix used C99 style of object initializations Signed-off-by: Sergey Oblomov <[email protected]>
|
@brminich could you review? |
brminich
approved these changes
Jul 25, 2018
|
I think we should keep UCX components in line with the rest of OMPI components, which use the ANSI style initialization. |
|
@yosefe there are lot of components where C99 init used (bml/r2, collectives, fs, mxm, etc), as I can see C99 is allowed in OMPI coding guidelines and it looks like much simpler to read |
|
@hoopoepg ok. Should we initialize the components (eg mca_pml_ucx_component) this way too? |
|
Yep, why not... |
Signed-off-by: Sergey Oblomov <[email protected]>
|
@yosefe done, pml/spml component init are updated too |
yosefe
approved these changes
Jul 28, 2018
|
@hoopoepg pls pick to v4.0.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sergey Oblomov [email protected]