Skip to content

Do not force 'hash' gds on direct modex in pmix4x #6504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2019
Merged

Do not force 'hash' gds on direct modex in pmix4x #6504

merged 1 commit into from
Mar 20, 2019

Conversation

jjhursey
Copy link
Member

  • Forcing the 'hash' gds component should not be necessary anymore.

@jjhursey
Do not force 'hash' gds on direct modex in pmix4x
1314cf2 
 * Forcing the 'hash' gds component should not be necessary any more.

Signed-off-by: Joshua Hursey <[email protected]>
@jjhursey jjhursey requested review from rhc54 and ggouaillardet March 19, 2019 16:54
@jjhursey
Copy link
Member Author

I missed this change for master from PR #6498

rhc54
rhc54 approved these changes Mar 19, 2019
View reviewed changes
Copy link
Contributor

@rhc54 rhc54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to adjust the ext2x component as well? I don't think you need to do the ext1x, but might be worth a quick glance

@jjhursey
Copy link
Member Author

The ext2x component was not impacted (it didn't have this code change). When we moved from the ext2x to the ext3x component is when we first noticed the regression.

I've tried to do a bit of digging to figure out why this was needed at the time it was introduced, and couldn't quite trace it back. We did some internal testing and it looked ok for our use case. I'm hoping that others will test their use cases in this mode to see if anything come up. If it does then they can always force the PMIX_MCA_gds=hash environment variable, so there is a workaround if it does become an issue. I don't think there will be, but you know just in case.

@jjhursey
Copy link
Member Author

bot:ompi:retest

@jjhursey jjhursey merged commit 53cd31e into open-mpi:master Mar 20, 2019
@jjhursey jjhursey deleted the rm-hash-pmix4 branch March 20, 2019 01:35
dsharma283 pushed a commit to dsharma283/ompi that referenced this pull request Jan 13, 2020
@jjhursey
Merge pull request open-mpi#6504 from jjhursey/rm-hash-pmix4
645e7da 
Do not force 'hash' gds on direct modex in pmix4x

Signed-off-by: Devesh Sharma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhc54 rhc54 rhc54 approved these changes

@ggouaillardet ggouaillardet Awaiting requested review from ggouaillardet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjhursey @rhc54