Skip to content

btl/uct: remove this from 4.0.x release branch #6643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

hppritcha
Copy link
Member

The UCX UCT layer is not really intended to be used outside
UCX itself. The OpenUCX community does not guarantee API
compatibility of the UCT layer between major releases.

we will leave the UCT BTL in master so it can be used for
experiments, etc. but will remove it from releases, at
least the 4.0.x release.

Fixes #6640

Signed-off-by: Howard Pritchard [email protected]

The UCX UCT layer is not really intended to be used outside
UCX itself.  The OpenUCX community does not guarantee API
compatibility of the UCT layer between major releases.

we will leave the UCT BTL in master so it can be used for
experiments, etc. but will remove it from releases, at
least the 4.0.x release.

Fixes open-mpi#6640

Signed-off-by: Howard Pritchard <[email protected]>
@hppritcha hppritcha added this to the v4.0.2 milestone May 8, 2019
@hppritcha hppritcha requested review from jladd-mlnx and gpaulsen May 8, 2019 21:00
@jladd-mlnx
Copy link
Member

👍

@hppritcha hppritcha changed the title btl/uct: remove this from 4.0.x release branche btl/uct: remove this from 4.0.x release branch May 8, 2019
@jsquyres
Copy link
Member

jsquyres commented May 8, 2019

@hppritcha I strongly suggest you do not remove this component from the v4.0.x branch -- it will break our backwards compatibility guarantees.

Instead, I suggest two things:

  1. Make this component's configure.m4 smarter to determine whether it can actually build or not (i.e., we should not get a compile error from btl/uct that blocks building the rest of OMPI).
  2. Make this component not be the default at run time. I understand that no one wants to support it, but we did ship it in v4.0, so we can't just delete it in mid-4.0.x stream. But we can make it not run by default, I think.

Thoughts?

@bosilca
Copy link
Member

bosilca commented May 8, 2019

@thananon

Copy link
Member

@jsquyres jsquyres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not merge this PR. It will break our backwards compatibility guarantees.

@hppritcha hppritcha closed this May 8, 2019
@gpaulsen
Copy link
Member

gpaulsen commented May 8, 2019

perhaps we can leave everything as-is, but add some configury to v4.0.x to disable building it by default.

@thananon
Copy link
Member

thananon commented May 8, 2019

I have no objection in removing it from 4.0.x but I just want to drop this here as a reference.

  • Without btl/uct and btl/ofi, we kinda lost osc/rdma support too. I'm not sure if each PML have their one-sided API implemented.
  • btl/uct is performing best in MT, even for two sided, by miles. If this get removed, when someone look for multithreaded support, we will have to point them to master instead.

@jsquyres
Copy link
Member

jsquyres commented May 8, 2019

We can't remove it from v4.0.x, and we should keep building it by default (if possible), because that's what we did in v4.0.0. Changing that in mid-stream of the v4.0.x release train is probably not a good idea (IMNSHO).

I'm personally in favor of the 2 recommendations I made above (#6643 (comment)). Other thoughts on that?

@rhc54
Copy link
Contributor

rhc54 commented May 8, 2019

I agree that it cannot be removed from v4.0.x, especially if it does function with at least some UCX versions and provides a performance benefit to boot. Seems to me that extending the configure logic to ensure it builds only with compatible UCX versions makes sense (along with something in the FAQ about supported versions), and it should remain as the default when it does build since that is the current priority. Question then becomes: who is going to do the configure update and the FAQ entry?

@hppritcha hppritcha deleted the topic/excise_uct_btl_from_v4.0.x branch October 29, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants