-
Notifications
You must be signed in to change notification settings - Fork 908
btl/uct: remove this from 4.0.x release branch #6643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
btl/uct: remove this from 4.0.x release branch #6643
Conversation
The UCX UCT layer is not really intended to be used outside UCX itself. The OpenUCX community does not guarantee API compatibility of the UCT layer between major releases. we will leave the UCT BTL in master so it can be used for experiments, etc. but will remove it from releases, at least the 4.0.x release. Fixes open-mpi#6640 Signed-off-by: Howard Pritchard <[email protected]>
👍 |
@hppritcha I strongly suggest you do not remove this component from the v4.0.x branch -- it will break our backwards compatibility guarantees. Instead, I suggest two things:
Thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not merge this PR. It will break our backwards compatibility guarantees.
perhaps we can leave everything as-is, but add some configury to v4.0.x to disable building it by default. |
I have no objection in removing it from 4.0.x but I just want to drop this here as a reference.
|
We can't remove it from v4.0.x, and we should keep building it by default (if possible), because that's what we did in v4.0.0. Changing that in mid-stream of the v4.0.x release train is probably not a good idea (IMNSHO). I'm personally in favor of the 2 recommendations I made above (#6643 (comment)). Other thoughts on that? |
I agree that it cannot be removed from v4.0.x, especially if it does function with at least some UCX versions and provides a performance benefit to boot. Seems to me that extending the configure logic to ensure it builds only with compatible UCX versions makes sense (along with something in the FAQ about supported versions), and it should remain as the default when it does build since that is the current priority. Question then becomes: who is going to do the configure update and the FAQ entry? |
The UCX UCT layer is not really intended to be used outside
UCX itself. The OpenUCX community does not guarantee API
compatibility of the UCT layer between major releases.
we will leave the UCT BTL in master so it can be used for
experiments, etc. but will remove it from releases, at
least the 4.0.x release.
Fixes #6640
Signed-off-by: Howard Pritchard [email protected]