Update dpm to handle deprecation of MPI_Info keys #7662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecate the current OMPI-specific MPI_Info key definitions for MPI_Comm_spawn and replace them with their PMIx equivalents. Issue a deprecation/conversion warning as this is done. Also issue deprecation warnings for options such as "ompi_non_mpi" that are no longer used. Handle both cases where the user might pass either the PMIx attribute name itself (e.g., "PMIX_MAPBY") or the string value of the attribute (e.g., PMIX_MAPBY, which translates to "pmix.mapby"). This can only be done for PMIx v4 and above, so protect that code. Silence a couple of Coverity warnings and add a test along the way. Signed-off-by: Ralph Castain <[email protected]>
ompiteam
approved these changes
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate the current OMPI-specific MPI_Info key definitions for
MPI_Comm_spawn and replace them with their PMIx equivalents. Issue a
deprecation/conversion warning as this is done. Also issue deprecation
warnings for options such as "ompi_non_mpi" that are no longer used.
Handle both cases where the user might pass either the PMIx attribute
name itself (e.g., "PMIX_MAPBY") or the string value of the attribute
(e.g., PMIX_MAPBY, which translates to "pmix.mapby"). This can only be
done for PMIx v4 and above, so protect that code.
Silence a couple of Coverity warnings and add a test along the way.
Fixes #7658
Signed-off-by: Ralph Castain [email protected]