Define the object class for the isendrecv request once. #9990
Conversation
This patch works, but the code is ugly, each file using a static structure and function which ends up being defined twice (for MPI and PMPI API). There is no better solution at the MPI API level that would not require adding additional files to move the structure declaration, callback implementations and the class implementation into. Signed-off-by: George Bosilca <[email protected]>
|
@bosilca Anther potential solution would be to put that data structure elsewhere, such as |
|
The use of these structures being limited to the MPI API layer makes them unsuitable for being moved into ompi/request/. Creating the ompi/mpi/c/base.c and ompi/mpi/c/base.h could be another approach, but this changes the way we build the MPI API (each file being self-sufficient). Thinking more about this, I don't think the approach is the best. We should have extended the PML/MTL API with sendrecv support, allowing the communication layer to provide optimized versions of these 2 functions. The implementation we have right now, is inefficient and memory consuming. |
This patch works, but the code is ugly, each file using a static
structure and function which ends up being defined twice (for MPI and
PMPI API). There is no better solution at the MPI API level that would
not require adding additional files to move the structure declaration,
callback implementations and the class implementation into.
Fixes #9985.
Signed-off-by: George Bosilca [email protected]