UCX/PML/SPML/OSC: fix compiler warnings #9997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoopoepg
approved these changes
Feb 10, 2022
Comment on lines
328
to
334
| void *fetch, | ||
| void *target, | ||
| uint64_t *prev, | ||
| uint64_t cond, | ||
| uint64_t value, | ||
| size_t size, | ||
| int pe) |
karasevb
force-pushed
the
pml_ucx_warnings_fix
branch
from
8f9f2ea to
9397261
Compare
hoopoepg
approved these changes
Feb 10, 2022
|
The IBM CI (XL) build failed! Please review the log, linked below. Gist: https://gist.github.com/cc048d76221442339dcc3d1675fc5901 |
|
bot:ibm:retest |
yosefe
reviewed
Feb 10, 2022
opal/mca/common/ucx/common_ucx.c
Outdated
| /* mlx5_0:1 */ | ||
| ret = sscanf(device_name, "%m[^:]%*d", &ib_device_name); | ||
| ret = sscanf(device_name, ib_device_name_fmt, &ib_device_name); | ||
| free(ib_device_name_fmt); |
There was a problem hiding this comment.
maybe ib_device_name_fmt could be fixed size on the stack, so no need to release
opal/mca/common/ucx/common_ucx.c
Outdated
| /* "# resource 6 : md 5 dev 4 flags -- rc_verbs/mlx5_0:1" */ | ||
| opal_asprintf(&rsc_name_fmt, | ||
| "# resource %%*d : md %%*d dev %%*d flags -- %%%u[^/ \n\r]/%%%u[^/ \n\r]", | ||
| NAME_MAX-1, NAME_MAX-1); |
There was a problem hiding this comment.
minor: space around minus operator
brminich
reviewed
Feb 10, 2022
opal/mca/common/ucx/common_ucx.c
Outdated
| @@ -298,17 +302,17 @@ OPAL_DECLSPEC opal_common_ucx_support_level_t opal_common_ucx_support_level(ucp_ | |||
| /* Print ucx transports information to the memory stream */ | |||
| ucp_context_print_info(context, stream); | |||
|
|
|||
| /* "# resource 6 : md 5 dev 4 flags -- rc_verbs/mlx5_0:1" */ | |||
| opal_asprintf(&rsc_name_fmt, | |||
There was a problem hiding this comment.
can use opal_snprintf here as well then?
yosefe
approved these changes
Feb 10, 2022
Signed-off-by: Boris Karasev <[email protected]>
karasevb
force-pushed
the
pml_ucx_warnings_fix
branch
from
c45575d to
334c6ec
Compare
brminich
approved these changes
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9984