[exporter/loki]: Attribute used as hint always added as loki label

[jonaskello]

Component(s)

exporter/loki

Describe the issue you're reporting

It seems like when I add a hint for org-id using loki.tenant it also becomes added as a loki label. This seems like an unnecessary overhead since it will always have the same value for the same tenant.

For example if I use the k8s.namespace.name resource attribute for loki.tenant it will also add a loki label called k8s_namespace_name which will always have the same value within the tenant.

processors:
  resource/loki_tenant_from_k8s_namespace:
    attributes:
    - action: insert
      key: loki.tenant
      value: k8s.namespace.name

Is automatcially adding a loki label for the loki.tenant hint value expected behavior or do I have a misconfiguration?

[github-actions]

Pinging code owners:

• exporter/loki: @gramidt @gouthamve @jpkrohling @kovrus @mar4uk

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[mar4uk]

That's a good question.
Probably we shouldn't promote the resource attribute that was used for loki.tenant hint to the label.
According to the README

In this case the value of the host.name resource attribute is used to group logs by tenant and send requests with the X-Scope-OrgID header set to relevant tenants.

I think setting X-Scope-OrgID should be enough to support multitenancy.
What do you think @kovrus? Do you recall why the promotion resource attribute to the label was introduced in multitenancy support https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/14930/files#diff-a688ab558d42636a615687f62332c493311362ccf58799b795b34cf2a2955604R52-R63?

[jpkrohling]

Probably an oversight, I agree the tenant should not be automatically promoted to a label.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• exporter/loki: @gramidt @gouthamve @jpkrohling @kovrus @mar4uk

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[mar4uk]

still relevant

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• exporter/loki: @gramidt @gouthamve @jpkrohling @mar4uk

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[mar4uk]

still relevant