[exporter/datadog] Error returned from authAPI.Validate is not propagated

[RonFed]

Component(s)

exporter/datadog

What happened?

Description

The error returned from Validate is not returned. I'm not sure if this is intentional or not. From debugging this and entering an invalid API key I see an error of 403 forbidden is returned but only logged.

opentelemetry-collector-contrib/exporter/datadogexporter/internal/clientutil/api.go

Lines 39 to 53 in 6ff2a8a

	func ValidateAPIKey(ctx context.Context, apiKey string, logger *zap.Logger, apiClient *datadog.APIClient) error {
	logger.Info("Validating API key.")
	authAPI := datadogV1.NewAuthenticationApi(apiClient)
	resp, httpresp, err := authAPI.Validate(GetRequestContext(ctx, apiKey))
	if err == nil && resp.Valid != nil && *resp.Valid {
	logger.Info("API key validation successful.")
	return nil
	}
	if err != nil {
	logger.Warn("Error while validating API key", zap.Error(err))
	return nil
	}
	logger.Warn(ErrInvalidAPI.Error())
	return WrapError(ErrInvalidAPI, httpresp)
	}

Collector version

v0.104.0

Environment information

No response

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response

[github-actions]

Pinging code owners:

• exporter/datadog: @mx-psi @dineshg13 @liustanley @songy23 @mackjmr @ankitpatel96

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[mx-psi]

@RonFed This is intentional and mimics the behavior of the Datadog Agent. To propagate the error you can set api::fail_on_invalid_key to true. Let me know if that is what you were looking for.

[RonFed]

@mx-psi I have tried this config but it still causes the error to not get propagated, since the function above is not returning it, it doesn't get sent in the error channel and the check for the configuration you proposed is not catching it in

opentelemetry-collector-contrib/exporter/datadogexporter/traces_exporter.go

Lines 70 to 90 in 0385b21

	// client to send running metric to the backend & perform API key validation
	errchan := make(chan error)
	if isMetricExportV2Enabled() {
	apiClient := clientutil.CreateAPIClient(
	params.BuildInfo,
	cfg.Metrics.TCPAddrConfig.Endpoint,
	cfg.ClientConfig)
	go func() { errchan <- clientutil.ValidateAPIKey(ctx, string(cfg.API.Key), params.Logger, apiClient) }()
	exp.metricsAPI = datadogV2.NewMetricsApi(apiClient)
	} else {
	client := clientutil.CreateZorkianClient(string(cfg.API.Key), cfg.Metrics.TCPAddrConfig.Endpoint)
	go func() { errchan <- clientutil.ValidateAPIKeyZorkian(params.Logger, client) }()
	exp.client = client
	}
	if cfg.API.FailOnInvalidKey {
	if err := <-errchan; err != nil {
	return nil, err
	}
	}
	return exp, nil
	}

[mx-psi]

I am taking a look at this. I filed #33944 but I am a bit confused as to why the endpoint would be returning 403 for something that should not need authentication, so I am checking internally as well :)