supervisor does not consistently use property "storage.directory" to store effective yaml, agent.log

[cforce]

Component(s)

cmd/opampsupervisor

What happened?

Observations from testing

config file changes
YAML

storage:
  directory: /home/root/myfolder/super_check

contents of /home/root/myfolder/super_check after running supervisor

root@:~/super# ls /home/root/myfolder/super_check
persistent_state.yaml

Contents of directory from where supervisor was run

root@:~/super# ls
agent.log         effective.yaml    otelcol supervisor     supervisor.yaml

storage: what we give applies for persistent_state.yaml file not effective yaml file.
effective.yaml file is still created in same directory from where supervisor was run

Collector version

master

Environment information

No response

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response

[github-actions]

Pinging code owners:

• cmd/opampsupervisor: @evan-bradley @atoulme @tigrannajaryan @BinaryFissionGames

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[BinaryFissionGames]

Yeah, we definitely should be putting any files the supervisor creates under the storage directory. I'll take this on.

[cforce]

After a first test it look like "effective.yaml" file is still in same directory as supervisor and not in the configured one.
The change shall cover all files which are created to be located only in the configured folder, shouldn't' it?
@BinaryFissionGames