Log response error with zap #1050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1050 +/- ##
==========================================
+ Coverage 88.81% 88.83% +0.01%
==========================================
Files 250 250
Lines 11924 11925 +1
==========================================
+ Hits 10590 10593 +3
+ Misses 990 989 -1
+ Partials 344 343 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
bogdandrutu
approved these changes
Sep 21, 2020
dyladan
referenced
this pull request
in dynatrace-oss-contrib/opentelemetry-collector-contrib
Jan 29, 2021
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
* Move proto to OTLP exporter * Update OTLP exporter import of proto * Use gogo protobuf To stop using the deprecated github.com/golang/protobuf and match what the collector is doing, switch to generating OTLP with the github.com/gogo/protobuf/proto instead of github.com/golang/protobuf/proto. * Clean dependencies Remove all protobuf dependencies from otel package and all of its dependencies. * Update CHANGELOG * Clean OTLP exporter go mod Remove submodule beforehand to avoid unneeded direct dependencies. * Use default ref for GitHub workflow * Update path that triggers proto gen action * Correct license-check exclusion for OTLP * Update commented location of the OTLP and code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently, even when an error is returned from an exporter, it doesn't seem to be automatically logged. I sort of expected it to but added manual logging instead.