SFx Exporter: copy_dimensions translator option #1126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
approved these changes
Sep 25, 2020
Codecov Report
@@ Coverage Diff @@
## master #1126 +/- ##
==========================================
- Coverage 89.01% 89.00% -0.02%
==========================================
Files 260 260
Lines 12413 12419 +6
==========================================
+ Hits 11050 11054 +4
- Misses 1011 1012 +1
- Partials 352 353 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
dyladan
referenced
this pull request
in dynatrace-oss-contrib/opentelemetry-collector-contrib
Jan 29, 2021
- Update Jaeger to v1.18.0, which deletes dependency on tchannel-go: `go get github.com/jaegertracing/[email protected]` - Tidy: `go mod tidy` Fixes #1126
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
It is not user-facing, so there is no reason to leave it in an importable location. Fixes #1126.
codeboten
pushed a commit
that referenced
this pull request
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adding a feature - Adding an SFx exporter translator option to allow copying existing dimensions within a datapoint. This is helpful if OTel conventions dictate a label have a certain form and the SFx built in content requires a dimension with a different name.
Testing:
Additional unit tests and manual validation.