AWSEMFExporter - Adding SummaryDataType, Remove MinMax from Histogram #1584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaochengwang
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1584 +/- ##
==========================================
- Coverage 89.33% 89.33% -0.01%
==========================================
Files 355 355
Lines 17601 17610 +9
==========================================
+ Hits 15724 15732 +8
- Misses 1397 1398 +1
Partials 480 480
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
anuraaga
approved these changes
Nov 14, 2020
|
Thanks for the PR |
dyladan
referenced
this pull request
in dynatrace-oss-contrib/opentelemetry-collector-contrib
Jan 29, 2021
* Make Kafka payload encoding configurable Signed-off-by: Pavol Loffay <[email protected]> * Expose marshalers in factory Signed-off-by: Pavol Loffay <[email protected]> * Remove zipkin from exporter readme Signed-off-by: Pavol Loffay <[email protected]> * Make custom encodings optional in the factory Signed-off-by: Pavol Loffay <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Inherited from #1564
Add SummaryDataType
Remove Min Max from Histogram data type
Link to tracking Issue:
#1510
Testing:
unit tests
manual end-to-end test
Documentation:
Add SummaryDataType since it's now supported
Remove Min Max from Histogram data type since the histogram buckets doesn't expose the Min and Max.