[signalfxexporter] Split incoming data requests by access token before enqueuing #1727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
force-pushed
the
signalfxsplit
branch
from
dfd4f0f to
2e06830
Compare
…e enqueuing Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
signalfxsplit
branch
from
2e06830 to
5fef5d1
Compare
|
Yes, they will be next |
Signed-off-by: Bogdan Drutu <[email protected]>
tigrannajaryan
approved these changes
Nov 30, 2020
| metricToken := s.retrieveAccessToken(rms.At(0)) | ||
|
|
||
| var sfxDataPoints []*sfxpb.DataPoint | ||
|
|
||
| for i := 0; i < rms.Len(); i++ { | ||
| rm := rms.At(i) | ||
| if rm.IsNil() { | ||
| continue | ||
| } |
There was a problem hiding this comment.
If we had debug asserts (if Go had them?) it would be useful to assert that s.retrieveAccessToken(rm)==metricToken. Maybe we need to add our own debug assert function (if it's even doable nicely in Go).
Nothing to do for now, but some food for thought.
rmfitzpatrick
approved these changes
Nov 30, 2020
Signed-off-by: Bogdan Drutu <[email protected]>
Signed-off-by: Bogdan Drutu <[email protected]>
Signed-off-by: Bogdan Drutu <[email protected]>
Signed-off-by: Bogdan Drutu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1727 +/- ##
=======================================
Coverage 89.55% 89.56%
=======================================
Files 373 374 +1
Lines 18234 18296 +62
=======================================
+ Hits 16330 16386 +56
- Misses 1414 1415 +1
- Partials 490 495 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
* Update SamplingParameters Remove HasRemoteParent fields from SamplingParameters. The HasRemoteParent field is a duplicate of the Remote field of the parent span context contained in the ParentContext. Change the `ParentContext` field from storing a `SpanContext` to a `context.Context` that holds the parent span. This is to conform with the OpenTelemetry specification and resolve #1727. * Update PR number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a possible memory corruption caused by the fact that the previous logic was deleting an element from the resource attributes, and the data could be shared between different exporters (exporters are not allowed to manipulate data).
Updates #1495
Signed-off-by: Bogdan Drutu [email protected]