Added setting to config to redact data of all types #37631
Merged
+137
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tiberius202
requested review from
dmitryax,
mx-psi,
TylerHelmuth and
a team
as code owners
The redaction is done based on its AsString value rather than SDR. This is based on this issue: open-telemetry#36684
|
I fixed the email. Sorry for the delay. I'm not a git wizard. I also started the CLA process |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@Tiberius202 any news about the CLA? |
|
Still waiting on my legal team. I'm surprised it is taking so long. I am reaching out to them today and am going to get this done. Thanks for your patience so far @mx-psi |
|
No worries, no rush at all :) |
…emetry#37196) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [google.golang.org/grpc](https://redirect.github.com/grpc/grpc-go) | `v1.69.2` -> `v1.69.4` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>grpc/grpc-go (google.golang.org/grpc)</summary> ### [`v1.69.4`](https://redirect.github.com/grpc/grpc-go/releases/tag/v1.69.4): Release 1.69.4 [Compare Source](https://redirect.github.com/grpc/grpc-go/compare/v1.69.2...v1.69.4) ### Bug Fixes - rbac: fix support for :path header matchers, which would previously never successfully match ([#&open-telemetry#8203;7965](https://redirect.github.com/grpc/grpc-go/issues/7965)). ### Documentation - examples/features/csm_observability: update example client and server to use the helloworld service instead of echo service ([#&open-telemetry#8203;7945](https://redirect.github.com/grpc/grpc-go/issues/7945)). </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS45Mi4wIiwidXBkYXRlZEluVmVyIjoiMzkuMTA3LjAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbImRlcGVuZGVuY2llcyIsInJlbm92YXRlYm90Il19--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <[email protected]> Co-authored-by: Yang Song <[email protected]>
|
@mx-psi I have done the CLA and fixed the old commit. Anything else that needs to be done? |
|
Please resolve the conflicts. |
mx-psi
reviewed
Mar 5, 2025
Co-authored-by: Pablo Baeyens <[email protected]>
Co-authored-by: Pablo Baeyens <[email protected]>
Co-authored-by: Pablo Baeyens <[email protected]>
Co-authored-by: Pablo Baeyens <[email protected]>
|
Please check the failing build, fix the issues and mark the PR as ready to review again. |
|
Thanks for marking it draft. Sorry about that. Been busy with work and meaning to fix these compile issues. I'll get it done soon, unmark this draft, and ping you all when it's time. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@mx-psi I think this is ready for another look |
This was referenced Apr 15, 2025
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
mx-psi
approved these changes
Jul 21, 2025
Co-authored-by: Pablo Baeyens <[email protected]>
povilasv
pushed a commit
to coralogix/opentelemetry-collector-contrib
that referenced
this pull request
Jul 29, 2025
…7631) Description The redaction is done based on its AsString value rather than SDR. This is based on this issue: open-telemetry#36684 The bug is that credit card numbers (as in the example on the README) are often provided as int numbers. The current redaction processor ignores all fields that are not of type int. Link to tracking issue open-telemetry#36684 Fixes No way to redact non string values Documentation I added the setting and turned it to true in the README as redacting un-delimited credit cards would definitely be under the scope of this setting. (This issue didn't pass the CLI due to the first commit not having an email) --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <[email protected]> Co-authored-by: Yang Song <[email protected]> Co-authored-by: Pablo Baeyens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The redaction is done based on its AsString value
rather than SDR. This is based on this issue:
#36684
The bug is that credit card numbers (as in the example on the README) are often provided as int numbers. The current redaction processor ignores all fields that are not of type int.
Link to tracking issue
#36684
Fixes No way to redact non string values
Documentation
I added the setting and turned it to true in the README as redacting un-delimited credit cards would definitely be under the scope of this setting.
(This issue didn't pass the CLI due to the first commit not having an email)