Skip to content

[receiver/hostmetrics] remove receiver.hostmetrics.normalizeProcessCPUUtilization feature gate #37641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Feb 3, 2025

Description

Link to tracking issue

Fixes #34763

@github-actions github-actions bot requested review from braydonk and dmitryax February 3, 2025 12:16
@odubajDT odubajDT marked this pull request as ready for review February 3, 2025 12:18
@odubajDT odubajDT requested a review from a team as a code owner February 3, 2025 12:18
Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this needs a changelog. The feature gate is stable, which means it can't be disabled. The functionality is already permanently enabled, so there isn't any impact to the end user.

@songy23
Copy link
Member

songy23 commented Feb 3, 2025

In theory this is a breaking change if I still have this FF like:

./otelcontribcol --feature-gates receiver.hostmetrics.normalizeProcessCPUUtilization

It works now as a no-op. It will panic after this PR.

@crobert-1
Copy link
Member

It works now as a no-op. It will panic after this PR.

That's fair. I'd think the breaking changelog entry for moving the feature gate to stable sufficiently covers it, but not a big deal. Thanks for including the example 👍

@songy23 songy23 merged commit 6d87048 into open-telemetry:main Feb 5, 2025
167 checks passed
@github-actions github-actions bot added this to the next release milestone Feb 5, 2025
chengchuanpeng pushed a commit to chengchuanpeng/opentelemetry-collector-contrib that referenced this pull request Feb 8, 2025
…PUUtilization` feature gate (open-telemetry#37641)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#34763

Signed-off-by: odubajDT <[email protected]>
zeck-ops pushed a commit to zeck-ops/opentelemetry-collector-contrib that referenced this pull request Apr 23, 2025
…PUUtilization` feature gate (open-telemetry#37641)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#34763

Signed-off-by: odubajDT <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[receiver/hostmetrics] Remove receiver.hostmetrics.normalizeProcessCPUUtilization feature gate
5 participants