[processor/resourcedetection] Add Dynatrace resource detector #37766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
github-actions
bot
added
the
processor/resourcedetection
bacherfl
changed the title
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
|
This should be ready for review now - not sure about the codeowners check, but i think this might be unrelated to this PR |
dashpole
reviewed
Feb 7, 2025
processor/resourcedetectionprocessor/internal/dynatrace/dynatrace.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
dashpole
approved these changes
Feb 10, 2025
dashpole
added
the
ready to merge
processor/resourcedetectionprocessor/internal/dynatrace/metadata.yaml
Outdated
Show resolved
Hide resolved
processor/resourcedetectionprocessor/internal/dynatrace/dynatrace.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
…on-host-name-only' into feat/37577/dt-resource-detection-host-name-only
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
…rce-detection-host-name-only
evan-bradley
approved these changes
Feb 12, 2025
dashpole
reviewed
Feb 12, 2025
…rce-detection-host-name-only
dashpole
approved these changes
Feb 12, 2025
|
Thank you for all the help @dashpole! |
khushijain21
pushed a commit
to khushijain21/opentelemetry-collector-contrib
that referenced
this pull request
Feb 14, 2025
…elemetry#37766) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PR adds the Dynatrace detector to the resource detection processor. The Dynatrace detector loads resource information from the `dt_host_metadata.properties` file which is located in the `/var/lib/dynatrace/enrichment` (on *nix systems) or `%ProgramData%\dynatrace\enrichment` (on Windows) directories. If present in the file, the following attributes will be added: - `dt.entity.host` - `host.name` The Dynatrace detector does not require any additional configuration, other than being added to the list of detectors. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#37577 <!--Describe what testing was performed and which tests were added.--> #### Testing Added unit tests <!--Describe the documentation added.--> #### Documentation Added a description of the detector to the readme <!--Please delete paragraphs that you did not use before submitting.--> --------- Signed-off-by: Florian Bacher <[email protected]> Co-authored-by: Evan Bradley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the Dynatrace detector to the resource detection processor.
The Dynatrace detector loads resource information from the
dt_host_metadata.propertiesfile which is located inthe
/var/lib/dynatrace/enrichment(on *nix systems) or%ProgramData%\dynatrace\enrichment(on Windows) directories.If present in the file, the following attributes will be added:
dt.entity.hosthost.nameThe Dynatrace detector does not require any additional configuration, other than being added to the list of detectors.
Link to tracking issue
Fixes #37577
Testing
Added unit tests
Documentation
Added a description of the detector to the readme