[receiver/splunkhecreceiver] timestamp accepts nano, micro, milli, and seconds #38637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
dehaansa
reviewed
Mar 15, 2025
| func convertTimestamp(sec float64) pcommon.Timestamp { | ||
| return pcommon.Timestamp(sec * 1e9) | ||
| /* | ||
| Splunk HEC timestamps can be in nanoseconds, microseconds, milliseconds, and seconds epoch. |
There was a problem hiding this comment.
Do you happen to have a documentation link for this statement?
There was a problem hiding this comment.
previous doc update missed milliseconds and that is being added. https://docs.splunk.com/Documentation/SplunkCloud/latest/Data/FormateventsforHTTPEventCollector#Event_metadata
it uses the |
This comment was marked as resolved.
This comment was marked as resolved.
|
Please add a changelog entry, start by executing |
My bad. done |
atoulme
approved these changes
Mar 18, 2025
atoulme
added
the
ready to merge
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
…d seconds (open-telemetry#38637) …d seconds <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Splunk HEC accepts nano, micro, milli, and sec. It will now guess the time before converting it to nanoseconds. to prevent overflow. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes [36571](open-telemetry#36571) <!--Describe what testing was performed and which tests were added.--> #### Testing unit test <!--Describe the documentation added.--> #### Documentation https://docs.splunk.com/Documentation/SplunkCloud/latest/Data/FormateventsforHTTPEventCollector#Event_metadata <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Antoine Toulme <[email protected]>
hapatel-splunk
pushed a commit
to hapatel-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
…d seconds (open-telemetry#38637) …d seconds <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Splunk HEC accepts nano, micro, milli, and sec. It will now guess the time before converting it to nanoseconds. to prevent overflow. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes [36571](open-telemetry#36571) <!--Describe what testing was performed and which tests were added.--> #### Testing unit test <!--Describe the documentation added.--> #### Documentation https://docs.splunk.com/Documentation/SplunkCloud/latest/Data/FormateventsforHTTPEventCollector#Event_metadata <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Antoine Toulme <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d seconds
Description
Splunk HEC accepts nano, micro, milli, and sec. It will now guess the time before converting it to nanoseconds. to prevent overflow.
Link to tracking issue
Fixes 36571
Testing
unit test
Documentation
https://docs.splunk.com/Documentation/SplunkCloud/latest/Data/FormateventsforHTTPEventCollector#Event_metadata