[connector/servicegraphconnector] Fix collect Client latency metrics bug #39184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
changed the title
|
@JaredTan95 @mapno please review. |
JaredTan95
reviewed
Apr 7, 2025
| note: Fix collectClientLatencyMetrics method bug | ||
|
|
||
| # Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. | ||
| issues: [39184] |
JaredTan95
approved these changes
Apr 7, 2025
JaredTan95
approved these changes
Apr 7, 2025
atoulme
approved these changes
Apr 7, 2025
atoulme
added
the
ready to merge
dmathieu
pushed a commit
to dmathieu/opentelemetry-collector-contrib
that referenced
this pull request
Apr 8, 2025
…bug (open-telemetry#39184) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description fix `collectClientLatencyMetrics` method bug. The `collectClientLatencyMetrics` method need to loop `reqClientDurationSecondsCount` var instead of `reqServerDurationSecondsCount`.
LucianoGiannotti
pushed a commit
to LucianoGiannotti/opentelemetry-collector-contrib
that referenced
this pull request
Apr 9, 2025
…bug (open-telemetry#39184) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description fix `collectClientLatencyMetrics` method bug. The `collectClientLatencyMetrics` method need to loop `reqClientDurationSecondsCount` var instead of `reqServerDurationSecondsCount`.
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
…bug (open-telemetry#39184) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description fix `collectClientLatencyMetrics` method bug. The `collectClientLatencyMetrics` method need to loop `reqClientDurationSecondsCount` var instead of `reqServerDurationSecondsCount`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix
collectClientLatencyMetricsmethod bug.The
collectClientLatencyMetricsmethod need to loopreqClientDurationSecondsCountvar instead ofreqServerDurationSecondsCount.