service resource attributes #39335
Merged
service resource attributes #39335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeitlinger
requested review from
dmitryax,
fatsheep9146,
TylerHelmuth,
ChrsMark and
a team
as code owners
ChrsMark
reviewed
Apr 15, 2025
| @@ -241,6 +245,8 @@ type ExtractionRules struct { | |||
|
|
|||
| Annotations []FieldExtractionRule | |||
| Labels []FieldExtractionRule | |||
|
|
|||
| Service bool | |||
There was a problem hiding this comment.
Just Service can be misleading. Can we use sth more explicit like ServiceAttributes instead?
|
@ChrsMark thanks for the review - I replied |
zeitlinger
force-pushed
the
automatic-resource-attributes
branch
from
98c5df7 to
4a10785
Compare
ChrsMark
reviewed
Apr 22, 2025
zeitlinger
force-pushed
the
automatic-resource-attributes
branch
from
4a10785 to
f46e096
Compare
|
@ChrsMark fixed (the changelog failure is a false positive) |
|
@dmitryax could you also take a look so we can unblock this one? |
zeitlinger
force-pushed
the
automatic-resource-attributes
branch
from
5c0bb01 to
d80875d
Compare
zeitlinger
force-pushed
the
automatic-resource-attributes
branch
from
90ecd28 to
0a574d1
Compare
dmitryax
reviewed
May 16, 2025
dmitryax
approved these changes
May 20, 2025
dragonlord93
pushed a commit
to dragonlord93/opentelemetry-collector-contrib
that referenced
this pull request
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
second part of #37114