Skip to content

[internal/aws] Migrate internal AWS module to use aws sdk v2 #39501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from

Conversation

seongpil0948
Copy link
Contributor

Description

Migrate internal AWS module to use aws sdk v2

Link to tracking issue

Fixes #37728

Testing

modify to fit SDK's changes

Documentation

This is mostly a behaviourally change, and shouldn't have any user impact but it is worth calling out.

component: internal/aws

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Upgrading internal/aws to adopt AWS SDK v2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the changelog, as this is invisible to users and no changes to the internal API are published outside this repository.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok thank u sir

@atoulme atoulme added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 18, 2025
@atoulme
Copy link
Contributor

atoulme commented Apr 18, 2025

Please be aware that #39497 seems to overlap you are setting out to perform. Since it was filed earlier and passes CI, it will probably be considered first.

@seongpil0948
Copy link
Contributor Author

seongpil0948 commented Apr 19, 2025

Please be aware that #39497 seems to overlap you are setting out to perform. Since it was filed earlier and passes CI, it will probably be considered first.

you are right, compared to other works, comply with the purpose of the issue(internal/aws comprehensive)
after that will go through the process of removing it according to passed PR

@seongpil0948 seongpil0948 requested a review from atoulme April 19, 2025 05:58
@seongpil0948
Copy link
Contributor Author

@atoulme
I will request it again with necessary logic and not overlap by module
I'm sorry to bother you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal/aws Skip Changelog PRs that do not require a CHANGELOG.md entry waiting-for-code-owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[internal/aws] migrate to AWS v2 SDK
2 participants