-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[internal/aws] Migrate internal AWS module to use aws sdk v2 #39501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
component: internal/aws | ||
|
||
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
note: Upgrading internal/aws to adopt AWS SDK v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove the changelog, as this is invisible to users and no changes to the internal API are published outside this repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok thank u sir
Please be aware that #39497 seems to overlap you are setting out to perform. Since it was filed earlier and passes CI, it will probably be considered first. |
you are right, compared to other works, comply with the purpose of the issue(internal/aws comprehensive) |
@atoulme |
Description
Migrate internal AWS module to use aws sdk v2
Link to tracking issue
Fixes #37728
Testing
modify to fit SDK's changes
Documentation
This is mostly a behaviourally change, and shouldn't have any user impact but it is worth calling out.