[extension/oidcauthextension] oidc ignore client/audience support #39595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
approved these changes
Apr 24, 2025
|
This was approved back then, lgtm. |
atoulme
added
ready to merge
|
Please check the CI |
zeck-ops
force-pushed
the
ignore-audience2
branch
from
4e892f6 to
21576ba
Compare
vincentfree
pushed a commit
to ing-bank/opentelemetry-collector-contrib
that referenced
this pull request
May 6, 2025
…en-telemetry#39595) A second attempt after my neglect of this old [PR](open-telemetry#36569). I do apologize for the inconvenience. Finally got the CLA figured out! Made a draft PR first this time to check. Adds support for ignoring the audience/clientid in OIDC. go-oidc has a [config option](https://github.com/coreos/go-oidc/blob/v3/oidc/verify.go#L94) for this, and the PR lets the collector use it. Fixes open-telemetry#36568 I built a custom collector, and tested with a couple of aws cognito app id / client ids and JWTs from them with and without the option enabled. Also added a unit test.
vincentfree
pushed a commit
to ing-bank/opentelemetry-collector-contrib
that referenced
this pull request
May 20, 2025
…en-telemetry#39595) A second attempt after my neglect of this old [PR](open-telemetry#36569). I do apologize for the inconvenience. Finally got the CLA figured out! Made a draft PR first this time to check. Adds support for ignoring the audience/clientid in OIDC. go-oidc has a [config option](https://github.com/coreos/go-oidc/blob/v3/oidc/verify.go#L94) for this, and the PR lets the collector use it. Fixes open-telemetry#36568 I built a custom collector, and tested with a couple of aws cognito app id / client ids and JWTs from them with and without the option enabled. Also added a unit test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A second attempt after my neglect of this old PR.
I do apologize for the inconvenience.
Finally got the CLA figured out! Made a draft PR first this time to check.
Adds support for ignoring the audience/clientid in OIDC.
go-oidc has a config option for this, and the PR lets the collector use it.
Fixes #36568
I built a custom collector, and tested with a couple of aws cognito app id / client ids and JWTs from them with and without the option enabled. Also added a unit test.